Show navbarCustomComponents in the sidebar on mobile#708
Merged
Conversation
Previously navbarCustomComponents were only rendered in the AppBar with
display: { xs: 'none', md: 'flex' } — hidden below md with no fallback,
so they simply disappeared on mobile. Desktop (md+) behavior is unchanged.
Below md, each component now also renders as its own row inside the
Drawer, grouped with the existing sidebarCustomComponent slot at the
bottom (both pinned together via a single mt: 'auto' wrapper), with
navbarCustomComponents rendering above sidebarCustomComponent.
Closes #707
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #707 —
navbarCustomComponentswere only rendered in the topAppBarwithdisplay: { xs: 'none', md: 'flex' }, so below themdbreakpoint they simply disappeared with no fallback.frontend/src/components/MenuBar.jsx:md+) AppBar rendering is unchanged.md, eachnavbarCustomComponentsentry now also renders as its own full-width row inside the sidebarDrawer.sidebarCustomComponent, both pinned to the bottom of the Drawer via one sharedmt: 'auto'wrapper —navbarCustomComponentsrows render abovesidebarCustomComponent, which stays visually last, matching its current position/behavior exactly whennavbarCustomComponentsis empty.No backend/context changes —
navbarCustomComponentsand itsstyleUrl/scriptUrlloading were already present inappContext; this is a frontend-only rendering change.Test plan
npx vitest run— 249 passed (35 files), including 3 new/updated cases inMenuBar.test.jsx:navbarCustomComponentsrender in both the AppBar and sidebar slotsnavbarCustomComponentsappears beforesidebarCustomComponentin DOM ordermt: 'auto'wrapper containing both blocks correctly pins the whole group to the bottom in either case (onlynavbarCustomComponents, onlysidebarCustomComponent, both, or neither)(Note:
npm run lintcurrently fails repo-wide due to a pre-existing ESLint flat-config incompatibility unrelated to this change — confirmed by running it against master before these edits.)Closes #707
🤖 Generated with Claude Code