Improve command result page visuals and add close-window hint#715
Merged
Conversation
The verify-enrollment, unsubscribe, and OAuth-integration result pages looked sparse and empty on desktop. Add the configured platform logo, let the card fill the viewport height (opt-in via a Layout fullHeight prop so other pages are unaffected), soften the card shadow, and show a "you can now close this window" hint after success/error results. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Dead-centering the content made it feel too low; use golden-ratio flex spacers (1 : 1.618) so it sits closer to the top instead. Also center-align the success/error alert text whenever the close-window hint is shown, to match the rest of the centered layout. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The 1:1.618 split was too subtle once the message block's own height ate most of the available whitespace. Use phi^2 (2.618) for the bottom spacer so the upward shift reads clearly at a glance. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The verify-enrollment, unsubscribe, and OAuth result pages can usually be traced back to an organization (via the enrollment, unsubscribe token, or course tied to the OAuth session). Resolve that organization and use its uploaded logo when set, falling back to the platform-wide DJANGO_EMAIL_LEARNING LOGO setting otherwise. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
command_result.html) looked sparse on desktop — the message sat near the top with a lot of empty space below.DJANGO_EMAIL_LEARNING["LOGO"], falling back to the default Django Email Learning logo, same light/dark logic asMenuBar.jsx) at the top of the card.fullHeightprop onLayout— other pages usingLayout(Assignment, Quiz, Organization, Course) are unaffected since the prop defaults tofalse.fullHeightmode.Test plan
ruff check/ruff format --checkon the touched Python filesverify_enrollment,unsubscribe,oauth) — 59 passed🤖 Generated with Claude Code