Commit 6f062f6
committed
fix: render platform fee separately in Cost line, not folded into ETH
Two related Copilot review findings:
- Read-only deployed runs were rendering "0.00000X ETH ($0.02)" — the
flat platform fee converted to ETH-equivalent looked like gas, even
though no on-chain action ran. Misleading.
- When Moralis isn't configured, the platform fee silently disappeared
from the rendered Cost line because USD→ETH conversion couldn't
proceed. The user's total understated by $0.02 with no signal.
Fix: stop folding executionFee into the native-ETH amount. Always emit
it as its own USD-denominated TokenTotal entry; renderer special-cases
Unit=="USD" to emit "$X platform fee".
Resulting renders:
⛽ Cost: 0.000003 ETH ($0.01), $0.02 platform fee (priced + on-chain)
⛽ Cost: 0.000003 ETH ($?), $0.02 platform fee (unpriced)
⛽ Cost: $0.02 platform fee (read-only)
Attribution stays clear: gas in ETH, value-fee per token, platform fee
in dollars. The platform fee is shown even without Moralis configured,
since its USD value is known directly.
Tests: TestFormatTelegramFromStructured_PlatformFeeOnly (read-only path)
and TestFormatTelegramFromStructured_NoPriceService (unpriced path).
Existing RunnerAndFees test updated to expect the separate platform fee.1 parent a8b70de commit 6f062f6
4 files changed
Lines changed: 85 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1549 | 1549 | | |
1550 | 1550 | | |
1551 | 1551 | | |
1552 | | - | |
1553 | | - | |
1554 | | - | |
1555 | | - | |
1556 | | - | |
| 1552 | + | |
| 1553 | + | |
| 1554 | + | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
1557 | 1558 | | |
1558 | 1559 | | |
1559 | 1560 | | |
| |||
1611 | 1612 | | |
1612 | 1613 | | |
1613 | 1614 | | |
| 1615 | + | |
| 1616 | + | |
| 1617 | + | |
| 1618 | + | |
| 1619 | + | |
| 1620 | + | |
| 1621 | + | |
| 1622 | + | |
| 1623 | + | |
| 1624 | + | |
| 1625 | + | |
| 1626 | + | |
1614 | 1627 | | |
1615 | 1628 | | |
1616 | 1629 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
347 | 347 | | |
348 | 348 | | |
349 | 349 | | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
350 | 355 | | |
351 | 356 | | |
352 | 357 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
264 | 264 | | |
265 | 265 | | |
266 | 266 | | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
267 | 273 | | |
268 | 274 | | |
269 | 275 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1035 | 1035 | | |
1036 | 1036 | | |
1037 | 1037 | | |
1038 | | - | |
| 1038 | + | |
| 1039 | + | |
1039 | 1040 | | |
1040 | 1041 | | |
1041 | 1042 | | |
| |||
1061 | 1062 | | |
1062 | 1063 | | |
1063 | 1064 | | |
1064 | | - | |
1065 | | - | |
1066 | | - | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
1067 | 1068 | | |
1068 | | - | |
1069 | | - | |
| 1069 | + | |
| 1070 | + | |
1070 | 1071 | | |
1071 | 1072 | | |
1072 | 1073 | | |
| |||
1081 | 1082 | | |
1082 | 1083 | | |
1083 | 1084 | | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
| 1123 | + | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
1084 | 1134 | | |
1085 | 1135 | | |
1086 | 1136 | | |
| |||
0 commit comments