Update getKeyRequest error message#257
Merged
chrisli30 merged 1 commit intoMay 19, 2025
Merged
Conversation
Co-Authored-By: Chris Li <chris.li.2046@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the signature decoding failure message for better user clarity.
- Replaces the old “Invalid Signature Format” text with a more descriptive prompt.
Comments suppressed due to low confidence (1)
core/auth/errors.go:5
- [nitpick] Error messages should follow the project’s style by omitting terminal punctuation and using sentence case; consider removing the trailing periods and adjusting to a single coherent sentence, e.g.:
Unable to decode client's signature; please check the message format.
InvalidSignatureFormat = "Unable to decode client's signature. Please check the message's format."
chrisli30
approved these changes
May 19, 2025
chrisli30
approved these changes
May 19, 2025
chrisli30
added a commit
that referenced
this pull request
May 21, 2025
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Chris Li <chris.li.2046@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update getKeyRequest error message
Description
This PR updates the error message for signature decoding failures to improve clarity for users. The message has been changed from "Invalid Signature Format" to "Unable to decode client's signature. Please check the message's format." as requested in issue #75.
Changes
InvalidSignatureFormatconstant incore/auth/errors.goTesting
Link to Devin run
https://app.devin.ai/sessions/6ce39e44d70a4b85b11b7bbce17c8781
Requested by
Chris Li (chris@avaprotocol.org)