Skip to content

fix: Uniswap sim state propagation, Sentry user-workflow noise #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisli30 merged 5 commits into from
Apr 22, 2026
Merged

fix: Uniswap sim state propagation, Sentry user-workflow noise #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3263c78
fix: silence expected user-workflow failures from Sentry error alerts…
chrisli30 Apr 16, 2026
2f71d77
fix: ERC20 approve state propagation for Uniswap workflow simulation …
chrisli30 Apr 17, 2026
88e9139
fix: skip Sepolia test on under-funded wallet, harden approve overrid…
will-dz Apr 22, 2026
4358d02
test: hard-fail Sepolia stop-loss test when prereqs missing
will-dz Apr 22, 2026
347bc2f
refactor: extract big.Int parsing into pkg/bigint to remove octal traps
will-dz Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion aggregator/rpc_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,11 @@ func (r *RpcServer) WithdrawFunds(ctx context.Context, payload *avsproto.Withdra
)

if err != nil {
r.config.Logger.Error("failed to send withdrawal UserOp",
// See preset.LogBundlerError: Warn on on-chain revert (user's withdrawal
// reverted — e.g. ERC20 transfer to blacklisted recipient, insufficient
// token balance after race), Error on infra/AA (bundler down, AA21, etc.).
preset.LogBundlerError(r.config.Logger, err,
"failed to send withdrawal UserOp",
"error", err,
"user", user.Address.String(),
"recipient", payload.RecipientAddress,
Expand Down
5 changes: 4 additions & 1 deletion core/taskengine/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3080,7 +3080,10 @@ func (n *Engine) SimulateTask(user *model.User, trigger *avsproto.TaskTrigger, n
cleanErrorMsg = stackTraceRegex.ReplaceAllString(cleanErrorMsg, "")
cleanErrorMsg = strings.TrimSpace(cleanErrorMsg)

n.logger.Error("workflow simulation completed with failures",
// User-workflow simulation failure: per-step errors are captured in the
// persisted execution steps. Log summary at Warn so it stays out of Sentry
// error alerts.
n.logger.Warn("workflow simulation completed with failures",
"error", cleanErrorMsg,
"task_id", task.Id,
"simulation_id", simulationID,
Expand Down
5 changes: 4 additions & 1 deletion core/taskengine/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,10 @@ func (x *TaskExecutor) RunTask(task *model.Task, queueData *QueueExecutionData)
case ExecutionSuccess:
x.logger.Info("task execution completed successfully", "task_id", task.Id, "execution_id", queueData.ExecutionID, "total_steps", len(vm.ExecutionLogs))
case ExecutionFailed:
x.logger.Error("task execution completed with failures",
// User-workflow failure: per-step errors are already logged at their sites
// and the ExecutionStatus_EXECUTION_STATUS_FAILED is persisted below. Log
// the summary at Warn so it stays out of Sentry error alerts.
x.logger.Warn("task execution completed with failures",
"error", executionError,
"task_id", task.Id,
"execution_id", queueData.ExecutionID,
Expand Down
Loading
Loading