Blank-out DeviceUniqueId.#6
Open
grokys wants to merge 3 commits into
Open
Conversation
Fixes #4.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to eliminate potential GDPR/PII risk by blanking out the DeviceUniqueId field in build telemetry, rather than deriving it from machine/user/environment inputs (issue #4).
Changes:
- Marks
DeviceUniqueIdas obsolete and stops populating it during payload initialisation. - Forces
DeviceUniqueIdto be empty when decoding payloads from disk. - Keeps the field in the binary payload format (still written during encoding), but intends to ensure it carries no identifying data.
To be compatible with data which has this field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible that
DeviceUniqueIdcould be considered PII by the GDPR (though open to interpretation) - remove it to be on the safe side.Fixes #4.