Use soname in WPEWebkit availability check#30
Open
shatyuka wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Linux WPE WebKit availability probe to load the libraries by their soname (*.so.1), aligning the check with the runtime-linked library names used by the WPE interop layer.
Changes:
- Switched the WPE library availability checks from unversioned
.sonames to soname.so.1names. - Simplified the check logic by removing explicit handle management.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+104
to
109
| if (!NativeLibrary.TryLoad("libWPEWebKit-2.0.so.1", out _)) | ||
| return false; | ||
| if (!NativeLibrary.TryLoad("libWPEBackend-fdo-1.0.so", out var fdoHandle)) | ||
| { | ||
| NativeLibrary.Free(webkitHandle); | ||
| if (!NativeLibrary.TryLoad("libWPEBackend-fdo-1.0.so.1", out _)) | ||
| return false; | ||
| } | ||
| if (!NativeLibrary.TryLoad("libwpe-1.0.so", out var wpeHandle)) | ||
| { | ||
| NativeLibrary.Free(fdoHandle); | ||
| NativeLibrary.Free(webkitHandle); | ||
| if (!NativeLibrary.TryLoad("libwpe-1.0.so.1", out _)) | ||
| return false; |
Contributor
Author
There was a problem hiding this comment.
Unloading a module is always troublesome, and it's almost never the case that these three modules don't coexist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.