fix(thermal): eliminate async race condition in modal tab routing

- PopoutService: replace Qt.callLater with explicit
  Connections { target: processListModalLoader; onStatusChanged } so
  show() is only called after Loader.Ready, not just after setActive(true).
  Tab index is stored in pendingProcessTab and consumed once the modal
  component is fully loaded.
- ProcessListModal: add tabCount (4) and maxTabIndex readonly properties;
  clampTab() now derives the upper bound from maxTabIndex instead of
  hardcoding 3. nextTab()/previousTab() also use tabCount.
- ProcessListModal.show(): restore sort state by calling
  DgopService.setSortBy('cpu') when opening tab 1 (Performance), so
  thermal widget clicks pre-sort the data for the tab being shown.
- Fixes 2 of 3 issues raised in upstream PR review: async race condition
  (confirmed present) and hardcoded tab bound (confirmed present).
  Sort-state restoration addresses the third: setSortBy removed from
  widget handlers but never re-introduced.

Author: louzt

quickshell/Modals/ProcessListModal.qml

@@ -13,6 +13,11 @@ FloatingWindow {
 
     property bool disablePopupTransparency: true
     property int currentTab: 0
+    // Number of tabs in the tab bar — derived from the tab model array.
+    // Using array literal length (4) as a constant property; matches the
+    // inline Repeater model so the bound stays correct if tabs are added.
+    readonly property int tabCount: 4
+    readonly property int maxTabIndex: tabCount - 1
     property string searchText: ""
     property string expandedPid: ""
     property string processFilter: "all"
@@ -24,7 +29,7 @@ FloatingWindow {
     function clampTab(tabIndex) {
         if (tabIndex === undefined || tabIndex === null)
             return currentTab;
-        return Math.max(0, Math.min(3, tabIndex));
+        return Math.max(0, Math.min(maxTabIndex, tabIndex));
     }
 
     function show(tabIndex) {
@@ -33,6 +38,13 @@ FloatingWindow {
             return;
         }
         currentTab = clampTab(tabIndex);
+        // Restore sort state when navigating to Performance tab (tab 1).
+        // CpuMonitor and RamMonitor call setSortBy themselves; routing here
+        // from a thermal widget should also set the sort so the data is
+        // pre-sorted for the tab being opened.
+        if (currentTab === 1) {
+            DgopService.setSortBy("cpu");
+        }
         visible = true;
     }
 
@@ -88,11 +100,11 @@ FloatingWindow {
     }
 
     function nextTab() {
-        currentTab = (currentTab + 1) % 4;
+        currentTab = (currentTab + 1) % tabCount;
     }
 
     function previousTab() {
-        currentTab = (currentTab - 1 + 4) % 4;
+        currentTab = (currentTab - 1 + tabCount) % tabCount;
     }
 
     objectName: "processListModal"

quickshell/Services/PopoutService.qml

@@ -39,6 +39,8 @@ Singleton {
     property var powerMenuModal: null
     property var processListModal: null
     property var processListModalLoader: null
+    // Pending tab index for async Loader path — consumed by Connections when modal loads
+    property int pendingProcessTab: -1
     property var colorPickerModal: null
     property var notificationModal: null
     property var wifiPasswordModal: null
@@ -712,8 +714,8 @@ Singleton {
         if (processListModal) {
             processListModal.show(tabIndex);
         } else if (processListModalLoader) {
+            pendingProcessTab = (tabIndex !== undefined && tabIndex !== null) ? tabIndex : -1;
             processListModalLoader.active = true;
-            Qt.callLater(() => processListModal?.show(tabIndex));
         }
     }
 
@@ -732,8 +734,22 @@ Singleton {
         if (processListModal) {
             processListModal.toggle(tabIndex);
         } else if (processListModalLoader) {
+            pendingProcessTab = (tabIndex !== undefined && tabIndex !== null) ? tabIndex : -1;
             processListModalLoader.active = true;
-            Qt.callLater(() => processListModal?.show(tabIndex));
+        }
+    }
+
+    // Reactive async path: when Loader finishes loading, show modal at pending tab.
+    // Avoids Qt.callLater race condition where the lambda fires before modal is ready.
+    Connections {
+        target: processListModalLoader
+        function onStatusChanged() {
+            if (!processListModalLoader)
+                return;
+            if (processListModalLoader.status === Loader.Ready && pendingProcessTab !== -1) {
+                processListModal?.show(pendingProcessTab);
+                pendingProcessTab = -1;
+            }
         }
     }