refactor(MediaPlayerSettings): integrate changes done on NightMode exceptions

- Use the appId matching function abstracted to Paths.qml.

- Use common appId normalization functions to append/remove from
settings list.

- Align with GammaControlTab app list input fields to fix bug where
white spaces only input would prevent field clearing on accept.

- Align with GammaControlTab and use a Loader for AppBrowserPopup so
that it can be recreated in case the popup is not closed with the
dedicated button (i.e., via the compositor).

Author: euletheia

quickshell/Common/SettingsData.qml

@@ -3163,10 +3163,6 @@ Singleton {
         saveSettings();
     }
 
-    function addMediaExcludePlayer(identity) {
-        if (identity === undefined || identity === null)
-            return;
-        var normalizedIdentity = identity.toString().trim().toLowerCase();
     function setNightModeExcludeFullscreen(enabled) {
         nightModeExcludeFullscreen = enabled;
         saveSettings();
@@ -3215,24 +3211,16 @@ Singleton {
         SessionData.resetNightModeExcludedAppsMatchesCache();
         saveSettings();
     }
-            return;
-        var list = mediaExcludePlayers ? mediaExcludePlayers.slice() : [];
-        var normalizedList = list.map(function (id) {
-            return id ? id.toString().trim().toLowerCase() : "";
-        });
-        if (normalizedList.indexOf(normalizedIdentity) >= 0)
-            return;
-        list.push(normalizedIdentity);
-        mediaExcludePlayers = list;
+
+    function addMediaExcludePlayer(identity) {
+        var newList = addAppIdToList(identity, mediaExcludePlayers);
+        mediaExcludePlayers = newList;
         saveSettings();
     }
 
     function removeMediaExcludePlayer(index) {
-        var list = mediaExcludePlayers ? mediaExcludePlayers.slice() : [];
-        if (index < 0 || index >= list.length)
-            return;
-        list.splice(index, 1);
-        mediaExcludePlayers = list;
+        var newList = removeAppIdFromList(index, mediaExcludePlayers);
+        mediaExcludePlayers = newList;
         saveSettings();
     }
 

quickshell/Modules/Settings/MediaPlayerTab.qml

@@ -18,6 +18,40 @@ Item {
         desktopApps = [];
     }
 
+    Loader {
+        id: popupLoader
+        active: false
+        sourceComponent: AppBrowserPopup {
+            id: appBrowserPopup
+            appsModel: root.desktopApps
+            parentModal: root.parentModal
+            onAppSelected: appId => {
+                var name = appId;
+                if (name.endsWith(".desktop")) {
+                    name = name.slice(0, -8);
+                }
+                SettingsData.addMediaExcludePlayer(name);
+            }
+        }
+
+        function recreatePopup() {
+            log.debug("Recreating popup");
+            popupLoader.active = false;
+            popupLoader.active = true;
+        }
+
+        function showPopup() {
+            if (!popupLoader.item) {
+                popupLoader.active = true;
+            }
+            popupLoader.item.show();
+            if (!popupLoader.item.visible) {
+                recreatePopup();
+                popupLoader.item.show();
+            }
+        }
+    }
+
     DankFlickable {
         anchors.fill: parent
         clip: true
@@ -166,10 +200,11 @@ Item {
                             placeholderText: I18n.tr("App name or identity (e.g., firefox)")
                             font.pixelSize: Theme.fontSizeSmall
                             onAccepted: {
-                                if (text.trim() !== "") {
-                                    SettingsData.addMediaExcludePlayer(text.trim());
-                                    text = "";
+                                var cleanInput = newExcludePlayerField.text.trim();
+                                if (cleanInput !== "") {
+                                    SettingsData.addMediaExcludePlayer(cleanInput);
                                 }
+                                text = "";
                             }
                         }
 
@@ -181,10 +216,11 @@ Item {
                             backgroundColor: Theme.primary
                             iconColor: Theme.onPrimary
                             onClicked: {
-                                if (newExcludePlayerField.text.trim() !== "") {
-                                    SettingsData.addMediaExcludePlayer(newExcludePlayerField.text.trim());
-                                    newExcludePlayerField.text = "";
+                                var cleanInput = newExcludePlayerField.text.trim();
+                                if (cleanInput !== "") {
+                                    SettingsData.addMediaExcludePlayer(cleanInput);
                                 }
+                                newExcludePlayerField.text = "";
                             }
                         }
 
@@ -195,7 +231,7 @@ Item {
                             iconSize: 20
                             backgroundColor: Theme.surfaceContainer
                             iconColor: Theme.primary
-                            onClicked: appBrowserPopup.show()
+                            onClicked: popupLoader.showPopup()
                         }
                     }
 
@@ -267,17 +303,4 @@ Item {
             }
         }
     }
-
-    AppBrowserPopup {
-        id: appBrowserPopup
-        appsModel: root.desktopApps
-        parentModal: root.parentModal
-        onAppSelected: appId => {
-            var name = appId;
-            if (name.endsWith(".desktop")) {
-                name = name.slice(0, -8);
-            }
-            SettingsData.addMediaExcludePlayer(name);
-        }
-    }
 }

quickshell/Services/MprisController.qml

@@ -17,28 +17,7 @@ Singleton {
         return players.filter(p => {
             const identity = (p.identity || "").toLowerCase();
             const desktopEntry = ("desktopEntry" in p && p.desktopEntry) ? String(p.desktopEntry).toLowerCase() : "";
-            return !excluded.some(ex => {
-                const exLower = String(ex).toLowerCase().trim();
-                if (!exLower) return false;
-
-                // 1. Substring match
-                if (identity.includes(exLower) || desktopEntry.includes(exLower))
-                    return true;
-
-                // 2. Match reverse-DNS segments (e.g. app.zen_browser.zen -> zen)
-                if (exLower.indexOf(".") !== -1) {
-                    const parts = exLower.split(".");
-                    const lastPart = parts[parts.length - 1];
-                    if (lastPart && (identity.includes(lastPart) || desktopEntry.includes(lastPart)))
-                        return true;
-                }
-
-                // 3. Bidirectional match (longer excluded name contains shorter player identity)
-                if (identity.length >= 3 && exLower.includes(identity))
-                    return true;
-
-                return false;
-            });
+            return !excluded.some(ex => Paths.isAppIdMatch(identity, ex, desktopEntry));
         });
     }
     property MprisPlayer activePlayer: null
@@ -86,10 +65,7 @@ Singleton {
     }
 
     function isIdle(player: MprisPlayer): bool {
-        return player
-            && player.playbackState === MprisPlaybackState.Stopped
-            && !player.trackTitle
-            && !player.trackArtist;
+        return player && player.playbackState === MprisPlaybackState.Stopped && !player.trackTitle && !player.trackArtist;
     }
 
     function _resolveActivePlayer(): void {