Skip to content

feat(Settings): add Settings window opacity option #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A1ca7raz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(Settings): add Settings window opacity option #2709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions quickshell/Common/SettingsData.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ Singleton {
property bool runUserMatugenTemplates: true
property string matugenTargetMonitor: ""
property real popupTransparency: 1.0
property real settingsModalOpacity: 1.0
property real dockTransparency: 1
property string widgetBackgroundColor: "sch"
property string widgetBackgroundCustomColor: "#6750A4"
Expand Down
1 change: 1 addition & 0 deletions quickshell/Common/settings/SettingsSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ var SPEC = {
matugenTargetMonitor: { def: "", onChange: "regenSystemThemes" },

popupTransparency: { def: 1.0, coerce: percentToUnit },
settingsModalOpacity: { def: 1.0, coerce: percentToUnit },
dockTransparency: { def: 1.0, coerce: percentToUnit },

widgetBackgroundColor: { def: "sch" },
Expand Down
13 changes: 6 additions & 7 deletions quickshell/Modals/Settings/SettingsModal.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ FloatingWindow {
minimumSize: Qt.size(500, 400)
implicitWidth: 900
implicitHeight: screen ? Math.min(940, screen.height - 100) : 940
color: Theme.surfaceContainer
color: "transparent"
visible: false

onIsCompactModeChanged: {
Expand Down Expand Up @@ -170,6 +170,11 @@ FloatingWindow {
}
}

Rectangle {
anchors.fill: parent
color: Theme.withAlpha(Theme.surfaceContainer, SettingsData.settingsModalOpacity)
}

FocusScope {
id: contentFocusScope

Expand All @@ -194,12 +199,6 @@ FloatingWindow {
onDoubleClicked: windowControls.tryToggleMaximize()
}

Rectangle {
anchors.fill: parent
color: Theme.surfaceContainer
opacity: 0.5
}

Row {
anchors.left: parent.left
anchors.leftMargin: Theme.spacingL
Expand Down
2 changes: 1 addition & 1 deletion quickshell/Modals/Settings/SettingsSidebar.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ Rectangle {
implicitWidth: __calculatedWidth
width: __calculatedWidth
height: parent.height
color: Theme.surfaceContainer
color: "transparent"
radius: Theme.cornerRadius

Component.onCompleted: {
Expand Down
14 changes: 14 additions & 0 deletions quickshell/Modules/Settings/ThemeColorsTab.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2033,6 +2033,20 @@ Item {
checked: SettingsData.modalDarkenBackground
onToggled: checked => SettingsData.set("modalDarkenBackground", checked)
}

SettingsSliderRow {
tab: "theme"
tags: ["modal", "settings", "transparency", "opacity", "background"]
settingKey: "settingsModalOpacity"
text: I18n.tr("Settings Window Opacity")
description: I18n.tr("Controls opacity of the Settings window background")
value: Math.round(SettingsData.settingsModalOpacity * 100)
minimum: 0
maximum: 100
unit: "%"
defaultValue: 100
onSliderValueChanged: newValue => SettingsData.set("settingsModalOpacity", newValue / 100)
}
}

SettingsCard {
Expand Down