feat(audio): add output port selection#2779
Open
wongcallum wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a button to each audio output device in the control center which opens an output port selection modal. This allows users to switch from e.g. speakers to headphones without having to open pavucontrol.
I decided to add a button cuz that's how KDE Plasma does it. Happy to switch to a dropdown if preferred.
Quickshell.Services.Pipewiredoesn't expose an interface to switch ports, so I usedpactlin a similar way to the existing Bluetooth codec selector, usingProc.runCommand. Ifpactlis missing or an error happens, the button doesn't appear, so there is no need to warn about that.This PR only handles output sinks, and only adds the selector to the control center and not the audio settings window. I'd like to open separate PRs for these to keep this one manageable. They should be fairly easy.
Type of change
Related issues
Closes #330
Screenshots / video
output-port-selection.mp4
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis clean (N/A)make lint-qmlwith no new warnings