fix(notifications): dismiss popups when senders close notifications#2815
Merged
bbedward merged 1 commit intoJul 10, 2026
Merged
Conversation
When a sender calls CloseNotification (per freedesktop spec) for a persistent notification (expire-timeout=0), the onDropped handler removed the wrapper from internal arrays but did not dismiss the visible popup. The popup remained on screen forever for non-critical notifications like YubiKey touch prompts. Set wrapper.popup=false in onDropped so the popup exits via the normal signal chain. This is minimal; it does not change timeout handling, queue management, or the isPersistent marker. Also reverts the previous workaround that special-cased non-critical expireTimeout=0 to use DMS timeout. Upstream spec-correct behavior is to honor the sender timeout, and fix the dismissal bug instead. Closes AvengeMedia#2814
c6a6f37 to
1398dd2
Compare
Purian23
pushed a commit
that referenced
this pull request
Jul 10, 2026
…2815) When a sender calls CloseNotification (per freedesktop spec) for a persistent notification (expire-timeout=0), the onDropped handler removed the wrapper from internal arrays but did not dismiss the visible popup. The popup remained on screen forever for non-critical notifications like YubiKey touch prompts. Set wrapper.popup=false in onDropped so the popup exits via the normal signal chain. This is minimal; it does not change timeout handling, queue management, or the isPersistent marker. Also reverts the previous workaround that special-cased non-critical expireTimeout=0 to use DMS timeout. Upstream spec-correct behavior is to honor the sender timeout, and fix the dismissal bug instead. Closes #2814 (cherry picked from commit 26b2955)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a notification sender calls
CloseNotificationper the freedesktop spec (e.g. YubiKey touch prompts sendingexpire-timeout=0thenCloseNotification(id)after touch), theonDroppedhandler removed the wrapper fromallWrappersandnotificationsarrays but never dismissed the visible popup. The popup remained on screen forever for non-critical notifications.Root cause
NotifWrapper.conn.onDropped()removes the wrapper from tracking arrays but does not setpopup=false. Sinceexpire-timeout=0persistent notifications never start a timer, no other code path dismisses them. The popup stays visible until manually dismissed or another popup replaces it.Fix
Single-file change in
NotificationService.qml: addwrapper.popup = falseinonDropped()so the popup exits through the normal signal chain (onPopupChanged→removeFromVisibleNotifications).This is minimal and does not:
expireTimeoutsemantics or timer interval logicreleaseWrapperDiff
Verification
dbus-monitorcapture confirmsyubikey-touch-detectorsendsNotify(expire_timeout=0)thenCloseNotification(id)after touchRelated
dbus-monitorcapture