feat(media): add toggle for album art accent colors (#2831)#2832
Merged
Purian23 merged 3 commits intoJul 12, 2026
Conversation
Closes AvengeMedia#2831 Removes ColorQuantizer-based album art accent extraction from MediaAccentService. All accent properties now return Theme.primary and Theme.onPrimary directly, so the Dank Dash player always matches the system colour scheme. Blame: ee6f7b4 (introduced MediaAccentService & ColorQuantizer) d799175 (tweaked seekbar accent colours) a62ae33 (further integrated accent into player/album art) c44ffae (monochrome art edge case fixes)
Collaborator
|
Hey @hthienloc, this move was intentional by our team, not a bug. At this stage, rather than revert it, I think we can add an option toggle to follow primary theme or follow album art themes. |
Member
Author
|
@Purian23 I can implement the toggle with default set to follow primary theme to maintain visual consistency, and users who prefer dynamic album art accents can opt in. |
hthienloc
changed the title
Adds mediaUseAlbumArtAccent setting (default: off) to Settings. When enabled, MediaAccentService extracts accent from album art via ColorQuantizer. When disabled, uses Theme.primary. Toggle is in Settings > Media Player.
hthienloc
force-pushed
the
feat/media-player-system-colors
branch
from
d28b942 to
25b5c65
Compare
Collaborator
That sounds okay by me. I'm indifferent on either option. We may need a default migration path, I haven't looked. |
hthienloc
changed the title
Collaborator
|
@hthienloc good to go? |
Member
Author
|
I think so. You can merge it now. |
dank-shell-app Bot
pushed a commit
that referenced
this pull request
Jul 12, 2026
* fix(media): use system colours in player instead of album cover accent Closes #2831 Removes ColorQuantizer-based album art accent extraction from MediaAccentService. All accent properties now return Theme.primary and Theme.onPrimary directly, so the Dank Dash player always matches the system colour scheme. Blame: ee6f7b4 (introduced MediaAccentService & ColorQuantizer) d799175 (tweaked seekbar accent colours) a62ae33 (further integrated accent into player/album art) c44ffae (monochrome art edge case fixes) * feat(media): add toggle for album art accent colours (#2831) Adds mediaUseAlbumArtAccent setting (default: off) to Settings. When enabled, MediaAccentService extracts accent from album art via ColorQuantizer. When disabled, uses Theme.primary. Toggle is in Settings > Media Player. * fix: use american english spelling (colour -> color) Port 1.5 (cherry picked from commit e2b3a2e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a toggle in Settings > Media Player to switch between system theme colors and album-art-extracted accent colors for the media player UI.
Default: Off (uses system
Theme.primaryfor visual consistency with the rest of the shell).When on: Extracts accent color from the current track's album art via
ColorQuantizerand applies it to player buttons, seekbar, album art border, and visualizer blob.Files changed:
Services/MediaAccentService.qml— RestoredColorQuantizerlogic, gated behindSettingsData.mediaUseAlbumArtAccent. Always returnsTheme.primary/Theme.onPrimarywhen the toggle is off.Common/SettingsData.qml— AddedmediaUseAlbumArtAccent: falseCommon/settings/SettingsSpec.js— AddedmediaUseAlbumArtAccent: { def: false }Modules/Settings/MediaPlayerTab.qml— AddedSettingsToggleRowType of change
Related issues
Closes #2831
Screenshots / video
N/A
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings