Skip to content

Commit bc5f302

Browse files
committed
Fix build for Windows & iOS
1 parent ef1c183 commit bc5f302

5 files changed

Lines changed: 25 additions & 7 deletions

File tree

.github/workflows/build_and_draft.yml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,11 @@ jobs:
135135
working-directory: ./VoiceCraft.Client/VoiceCraft.Client.iOS
136136
steps:
137137
- uses: actions/checkout@v5
138+
- name: Select Xcode 26.4.1
139+
run: |
140+
sudo xcode-select -s /Applications/Xcode_26.4.1.app
141+
xcodebuild -version
142+
138143
- name: Setup Dotnet
139144
uses: actions/setup-dotnet@v5
140145
with:
@@ -144,7 +149,7 @@ jobs:
144149
run: dotnet workload restore
145150

146151
- name: Publish Build (Unsigned IPA)
147-
run: dotnet publish -c Release -r ios-arm64 -p:BuildIpa=true -p:EnableCodeSigning=false -p:ValidateXcodeVersion=false
152+
run: dotnet publish -c Release -r ios-arm64 -p:BuildIpa=true -p:EnableCodeSigning=false
148153

149154
- name: Upload Artifact
150155
uses: actions/upload-artifact@v6
@@ -163,6 +168,11 @@ jobs:
163168
working-directory: ./VoiceCraft.Client/VoiceCraft.Client.MacOS
164169
steps:
165170
- uses: actions/checkout@v5
171+
- name: Select Xcode 26.4.1
172+
run: |
173+
sudo xcode-select -s /Applications/Xcode_26.4.1.app
174+
xcodebuild -version
175+
166176
- name: Setup Dotnet
167177
uses: actions/setup-dotnet@v5
168178
with:
@@ -175,7 +185,7 @@ jobs:
175185
run: dotnet restore -r osx-${{ matrix.arch }}
176186

177187
- name: Publish Build
178-
run: dotnet publish -c Release -r osx-${{ matrix.arch }} --no-restore -p:ValidateXcodeVersion=false
188+
run: dotnet publish -c Release -r osx-${{ matrix.arch }} --no-restore
179189

180190
- name: Build VoiceCraft.Client.MacOS.${{ matrix.arch }}.dmg
181191
run: |

.github/workflows/build_test.yml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,11 @@ jobs:
155155
working-directory: ./VoiceCraft.Client/VoiceCraft.Client.iOS
156156
steps:
157157
- uses: actions/checkout@v5
158+
- name: Select Xcode 26.4.1
159+
run: |
160+
sudo xcode-select -s /Applications/Xcode_26.4.1.app
161+
xcodebuild -version
162+
158163
- name: Setup Dotnet
159164
uses: actions/setup-dotnet@v5
160165
with:
@@ -164,7 +169,7 @@ jobs:
164169
run: dotnet workload restore
165170

166171
- name: Publish Build (Unsigned IPA)
167-
run: dotnet publish -c Release -r ios-arm64 -p:BuildIpa=true -p:EnableCodeSigning=false -p:ValidateXcodeVersion=false
172+
run: dotnet publish -c Release -r ios-arm64 -p:BuildIpa=true -p:EnableCodeSigning=false
168173

169174
- name: Upload Artifact
170175
uses: actions/upload-artifact@v6
@@ -183,6 +188,11 @@ jobs:
183188
working-directory: ./VoiceCraft.Client/VoiceCraft.Client.MacOS
184189
steps:
185190
- uses: actions/checkout@v5
191+
- name: Select Xcode 26.4.1
192+
run: |
193+
sudo xcode-select -s /Applications/Xcode_26.4.1.app
194+
xcodebuild -version
195+
186196
- name: Setup Dotnet
187197
uses: actions/setup-dotnet@v5
188198
with:
@@ -195,7 +205,7 @@ jobs:
195205
run: dotnet restore -r osx-${{ matrix.arch }}
196206

197207
- name: Publish Build
198-
run: dotnet publish -c Release -r osx-${{ matrix.arch }} --no-restore -p:ValidateXcodeVersion=false
208+
run: dotnet publish -c Release -r osx-${{ matrix.arch }} --no-restore
199209

200210
- name: Build VoiceCraft.Client.MacOS.${{ matrix.arch }}.dmg
201211
run: |

Directory.Packages.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<PackageVersion Include="Avalonia.iOS" Version="$(AvaloniaVersion)" />
1515
<PackageVersion Include="Avalonia.Browser" Version="$(AvaloniaVersion)" />
1616
<PackageVersion Include="Avalonia.Android" Version="$(AvaloniaVersion)" />
17-
<PackageVersion Include="SkiaSharp.NativeAssets.Win32" Version="3.119.3-preview.1.1" />
17+
<PackageVersion Include="SkiaSharp.NativeAssets.Win32" Version="3.119.4-preview.1.1" />
1818
<PackageVersion Include="SkiaSharp.NativeAssets.WebAssembly" Version="3.119.4-preview.1.1" />
1919
<PackageVersion Include="HarfBuzzSharp.NativeAssets.Win32" Version="8.3.1.3" />
2020
<PackageVersion Include="Fleck" Version="1.2.0" />

VoiceCraft.Client/VoiceCraft.Client.MacOS/VoiceCraft.Client.MacOS.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
<InfoPlist>Info.plist</InfoPlist>
1212
<ApplicationVersion>$(Version)</ApplicationVersion>
1313
<ApplicationDisplayVersion>$(Version)</ApplicationDisplayVersion>
14-
<ValidateXcodeVersion>false</ValidateXcodeVersion>
1514
<Nullable>enable</Nullable>
1615
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
1716
<TrimMode>link</TrimMode>

VoiceCraft.Client/VoiceCraft.Client.iOS/VoiceCraft.Client.iOS.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
<BuildIpa>true</BuildIpa>
1212
<ArchiveOnBuild>false</ArchiveOnBuild>
1313
<EnableCodeSigning>false</EnableCodeSigning>
14-
<ValidateXcodeVersion>false</ValidateXcodeVersion>
1514
<AppIcon>AppIcon</AppIcon>
1615
<XSAppIconAssets>Resources/Assets.xcassets/AppIcon.appiconset</XSAppIconAssets>
1716
<Nullable>enable</Nullable>

0 commit comments

Comments
 (0)