fix: support binary plist bundle version sync

Author: linhay

scripts/sync-macos-bundle-version.sh

@@ -41,22 +41,7 @@ print(match.group(1))
 PY
 )"
 
-python3 - "${PLIST_PATH}" "${BUNDLE_VERSION}" <<'PY'
-import plistlib
-import sys
-from pathlib import Path
-
-plist_path = Path(sys.argv[1])
-bundle_version = sys.argv[2]
-
-with plist_path.open("rb") as handle:
-    data = plistlib.load(handle)
-
-data["CFBundleShortVersionString"] = bundle_version
-data["CFBundleVersion"] = bundle_version
-
-with plist_path.open("wb") as handle:
-    plistlib.dump(data, handle, sort_keys=False)
-PY
+/usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString ${BUNDLE_VERSION}" "${PLIST_PATH}"
+/usr/libexec/PlistBuddy -c "Set :CFBundleVersion ${BUNDLE_VERSION}" "${PLIST_PATH}"
 
 echo "Synced macOS bundle version to ${BUNDLE_VERSION} in ${PLIST_PATH}"

scripts_macos_bundle_version_test.go

@@ -30,6 +30,25 @@ func TestSyncMacOSBundleVersionScript(t *testing.T) {
 		}
 	})
 
+	t.Run("syncs binary plist bundle metadata", func(t *testing.T) {
+		appPath := createTempAppBundle(t)
+		convertPlistToBinary(t, filepath.Join(appPath, "Contents", "Info.plist"))
+
+		cmd := exec.Command("bash", "scripts/sync-macos-bundle-version.sh", appPath, "v0.1.11")
+		output, err := cmd.CombinedOutput()
+		if err != nil {
+			t.Fatalf("sync-macos-bundle-version.sh error = %v, output = %s", err, output)
+		}
+
+		plist := readPlistAsJSON(t, filepath.Join(appPath, "Contents", "Info.plist"))
+		if got := plist["CFBundleShortVersionString"]; got != "0.1.11" {
+			t.Fatalf("CFBundleShortVersionString = %#v, want %q", got, "0.1.11")
+		}
+		if got := plist["CFBundleVersion"]; got != "0.1.11" {
+			t.Fatalf("CFBundleVersion = %#v, want %q", got, "0.1.11")
+		}
+	})
+
 	t.Run("rejects non release version", func(t *testing.T) {
 		appPath := createTempAppBundle(t)
 
@@ -91,3 +110,13 @@ func readPlistAsJSON(t *testing.T, plistPath string) map[string]any {
 
 	return data
 }
+
+func convertPlistToBinary(t *testing.T, plistPath string) {
+	t.Helper()
+
+	cmd := exec.Command("plutil", "-convert", "binary1", plistPath)
+	output, err := cmd.CombinedOutput()
+	if err != nil {
+		t.Fatalf("plutil binary convert error = %v, output = %s", err, output)
+	}
+}