chore: Replace acap-build crate with external rs4a-eap#239
Draft
apljungquist wants to merge 1 commit into
Draft
Conversation
Remove the in-tree `acap-build` crate and depend on the `rs4a-eap` crate from apljungquist/rs4acap instead. This has benefits in two categories: - Clarifies the purpose of this repo as facilitating the use of Rust in ACAP app implementations - `rs4a-eap` has several implemented and planned improvements, notably the option to not depend on external programs allowing it to be fully installed with cargo, and more robust testing. We drop all use of the reference implementation, which rs4a does not support and instead rely on the testing done by the library maintainer (me). The approach was flawed anyway since bugs could creep in when staging files in a temporary directory.
apljungquist
commented
Jul 9, 2026
| .args(args) | ||
| .artifact_dir(get_cargo_metadata(None)?.target_directory.join("acap")) | ||
| .execute()?; | ||
| .execute(cli.source_date_epoch.unwrap_or_default())?; |
Collaborator
Author
There was a problem hiding this comment.
This doesn't actually match the docstring:
Defaults to the current time.
I need to fix that.
I may move the interpolation into execute or some other shared location.
apljungquist
changed the title
acap-build crate with external rs4a-eap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is still work in progress, I still want to land a few more changes in rs4a and publish the crate.
That said, early feedback is welcome, in particular on issues such as:
Remove the in-tree
acap-buildcrate and depend on thers4a-eapcrate from apljungquist/rs4acap instead. This has benefits in two categories:rs4a-eaphas several implemented and planned improvements, notably the option to not depend on external programs allowing it to be fully installed with cargo, and more robust testing.We drop all use of the reference implementation, which rs4a does not support and instead rely on the testing done by the library maintainer (me). The approach was flawed anyway since bugs could creep in when staging files in a temporary directory.
Footers
Related-to: #205 (abandoned attempt at not shelling out to
cp, a problem that does not affectrs4a-eap)