Conversation
We have a "Category: CI" label in GH issues and PRs, but there is no labeler rule to automatically mark PRs as such. This adds a labeler rule to automatically add the "Category: CI" label if the PR changes _any_ file in: - .circleci/* - .github/actions/**/* - .github/CODEOWNERS - .github/setup_hmailserver.php - .github/nightly_matrix.php - .github/scripts/* - .github/scripts/**/* - .github/labeler.yml - .github/workflows/*
ZEND_ASSERT() is a no-op with gcov. Move zend_verify_internal_return_type() out of ZEND_ASSERT().
…onse_header via a dynamic fetch And thus remove the TODO message in zend_compile.c.
This now also specifies which argument is causing the error.
…hes flags These are mostly useful for C++ code, i.e. ext-intl. See: https://gcovr.com/en/stable/faq.html#why-does-c-code-have-so-many-uncovered-branches Closes phpGH-21655
Fixes mixed indentation from the previous PR phpGH-16915.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a "Category: CI" label in GH issues and PRs, but there is no
labeler rule to automatically mark PRs as such.
This adds a labeler rule to automatically add the "Category: CI" label
if the PR changes any file in: