Skip to content

Externalize emblem rendering#1221

Open
Blipz wants to merge 3 commits intoAzgaar:masterfrom
Blipz:master
Open

Externalize emblem rendering#1221
Blipz wants to merge 3 commits intoAzgaar:masterfrom
Blipz:master

Conversation

@Blipz
Copy link
Copy Markdown

@Blipz Blipz commented Jul 18, 2025

Description

Let Armoria API handle the emblem rendering.
See Azgaar/armoria-api#6 and Azgaar/Armoria#161

Question remains if the API will support the load and if we won't reach some Vercel limitation with the Hobby plan.

Use Armoria NPM package to handle the emblem rendering.

Type of change

  • Bug fix
  • New feature
  • Refactoring / style
  • Documentation update / chore
  • Other (please describe)

Versioning

  • Version is updated
  • Changed files hash is updated

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 18, 2025

Deploy Preview for afmg ready!

Name Link
🔨 Latest commit e8139ab
🔍 Latest deploy log https://app.netlify.com/projects/afmg/deploys/687a35c60c9f580008a92372
😎 Deploy Preview https://deploy-preview-1221--afmg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates the Armoria NPM package to handle emblem/coat of arms rendering locally, replacing the previously considered Armoria API approach.

Changes:

  • Adds armoria as a local file dependency pointing to a sibling directory (../armoria/dist)
  • Adds symlink-dir as a dev dependency to symlink the Armoria charges directory into public/charges
  • Adds a postinstall script to automatically create the symlink after npm install

},
"dependencies": {
"alea": "^1.0.1",
"armoria": "file:../armoria/dist",
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The armoria dependency is specified as a local file path (file:../armoria/dist), which means it points to a sibling directory on the developer's local machine. This will fail for any contributor or CI environment that does not have the armoria repository checked out at exactly ../armoria. The PR description mentions it is an NPM package — it should be referenced by a published NPM package name and version (e.g., "armoria": "^x.y.z") or a specific GitHub repository reference instead.

Suggested change
"armoria": "file:../armoria/dist",
"armoria": "latest",

Copilot uses AI. Check for mistakes.
"scripts": {
"dev": "vite",
"build": "tsc && vite build",
"postinstall": "symlink-dir ../node_modules/armoria/charges public/charges",
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The postinstall script symlinks from ../node_modules/armoria/charges, but since armoria is installed from file:../armoria/dist, its actual location in node_modules may differ (it could resolve differently depending on the package manager and file-link handling). Additionally, symlink-dir is a dev dependency, meaning this postinstall script will fail in production installs (e.g., npm install --omit=dev). Consider moving symlink-dir to dependencies, or replacing the postinstall approach with a Vite plugin or build step that copies/links the charges directory.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants