Conversation
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR integrates the Armoria NPM package to handle emblem/coat of arms rendering locally, replacing the previously considered Armoria API approach.
Changes:
- Adds
armoriaas a local file dependency pointing to a sibling directory (../armoria/dist) - Adds
symlink-diras a dev dependency to symlink the Armoria charges directory intopublic/charges - Adds a
postinstallscript to automatically create the symlink afternpm install
| }, | ||
| "dependencies": { | ||
| "alea": "^1.0.1", | ||
| "armoria": "file:../armoria/dist", |
There was a problem hiding this comment.
The armoria dependency is specified as a local file path (file:../armoria/dist), which means it points to a sibling directory on the developer's local machine. This will fail for any contributor or CI environment that does not have the armoria repository checked out at exactly ../armoria. The PR description mentions it is an NPM package — it should be referenced by a published NPM package name and version (e.g., "armoria": "^x.y.z") or a specific GitHub repository reference instead.
| "armoria": "file:../armoria/dist", | |
| "armoria": "latest", |
| "scripts": { | ||
| "dev": "vite", | ||
| "build": "tsc && vite build", | ||
| "postinstall": "symlink-dir ../node_modules/armoria/charges public/charges", |
There was a problem hiding this comment.
The postinstall script symlinks from ../node_modules/armoria/charges, but since armoria is installed from file:../armoria/dist, its actual location in node_modules may differ (it could resolve differently depending on the package manager and file-link handling). Additionally, symlink-dir is a dev dependency, meaning this postinstall script will fail in production installs (e.g., npm install --omit=dev). Consider moving symlink-dir to dependencies, or replacing the postinstall approach with a Vite plugin or build step that copies/links the charges directory.
Description
Let Armoria API handle the emblem rendering.See Azgaar/armoria-api#6 and Azgaar/Armoria#161
Question remains if the API will support the load and if we won't reach some Vercel limitation with the Hobby plan.Use Armoria NPM package to handle the emblem rendering.
Type of change
Versioning