Skip to content

Externalize emblem rendering #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Blipz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Externalize emblem rendering #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac187b2
Externalize emblem rendering
Blipz Mar 7, 2026
85f52e8
Fix formatting
Blipz Mar 7, 2026
6ced967
Adapt generator
Blipz Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
.idea
/node_modules
*/node_modules
/public/charges
/dist
/coverage
/playwright-report
/test-results
/test-results
156 changes: 153 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"scripts": {
"dev": "vite",
"build": "tsc && vite build",
"postinstall": "symlink-dir ../node_modules/armoria/charges public/charges",
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The postinstall script symlinks from ../node_modules/armoria/charges, but since armoria is installed from file:../armoria/dist, its actual location in node_modules may differ (it could resolve differently depending on the package manager and file-link handling). Additionally, symlink-dir is a dev dependency, meaning this postinstall script will fail in production installs (e.g., npm install --omit=dev). Consider moving symlink-dir to dependencies, or replacing the postinstall approach with a Vite plugin or build step that copies/links the charges directory.

Copilot uses AI. Check for mistakes.
"preview": "vite preview",
"test": "vitest",
"test:browser": "vitest --config=vitest.browser.config.ts",
Expand All @@ -39,9 +40,11 @@
},
"dependencies": {
"alea": "^1.0.1",
"armoria": "file:../armoria/dist",
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The armoria dependency is specified as a local file path (file:../armoria/dist), which means it points to a sibling directory on the developer's local machine. This will fail for any contributor or CI environment that does not have the armoria repository checked out at exactly ../armoria. The PR description mentions it is an NPM package — it should be referenced by a published NPM package name and version (e.g., "armoria": "^x.y.z") or a specific GitHub repository reference instead.

Suggested change
"armoria": "file:../armoria/dist",
"armoria": "latest",

Copilot uses AI. Check for mistakes.
"d3": "^7.9.0",
"delaunator": "^5.0.1",
"polylabel": "^2.0.1"
"polylabel": "^2.0.1",
"symlink-dir": "^9.0.0"
},
"engines": {
"node": ">=24.0.0"
Expand Down
Loading