fix: GeoJSON export#1283
Merged
Merged
Conversation
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SheepFromHeaven
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix GeoJSON export functionality by changing how coordinate conversion functions access global variables. The changes replace indirect access via (window as any) with direct global variable references for mapCoordinates, graphWidth, and graphHeight.
Changes:
- Modified global variable access in coordinate conversion functions from
windowproperties to direct global references - Added TypeScript global variable declarations for
mapCoordinates,graphWidth, andgraphHeight - Added comprehensive unit tests for coordinate conversion functions (
getLongitude,getLatitude,getCoordinates) - Added GitHub Actions workflow for running unit tests on pull requests
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/utils/index.ts | Changed variable access from (window as any).mapCoordinates/graphWidth/graphHeight to direct references |
| src/utils/commonUtils.ts | Added global variable type declarations for the three variables |
| src/utils/commonUtils.test.ts | Added comprehensive unit tests for coordinate conversion functions with edge cases |
| .github/workflows/unit-tests.yml | Added CI workflow for running unit tests on PRs to master branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Versioning