refactor: migrate cultures generator#1287
Merged
Merged
Conversation
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the cultures generator module from JavaScript to TypeScript, continuing the gradual migration of the codebase to TypeScript. The migration involves converting the module from a traditional JavaScript file loaded via script tag to a TypeScript module that's bundled by Vite during the build process.
Changes:
- Migrated
public/modules/cultures-generator.jstosrc/modules/cultures-generator.tswith TypeScript types and interfaces - Added Culture interface export and proper type annotations throughout the module
- Updated global type definitions and PackedGraph interface to support the new TypeScript module
- Removed the script tag from index.html as the module is now bundled by Vite
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/cultures-generator.ts | New TypeScript module with culture generation, expansion, and management logic |
| public/modules/cultures-generator.js | Deleted - replaced by TypeScript version |
| src/index.html | Removed script tag for cultures-generator.js (now bundled) |
| src/modules/index.ts | Added import for new cultures-generator module |
| src/types/global.ts | Added global type declarations for DOM elements and libraries used by cultures module |
| src/types/PackedGraph.ts | Added Culture interface import and cultures array to PackedGraph type |
Azgaar
approved these changes
Jan 26, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
it's ready now |
Owner
|
Please solve the conflicts and I will merge :) |
Collaborator
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Versioning