refactor: migrate burg module#1288
Merged
Merged
Conversation
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the burgs-generator module from JavaScript to TypeScript as part of the ongoing codebase modernization effort. The migration removes the old public/modules/burgs-generator.js file, creates a new TypeScript version at src/modules/burgs-generator.ts, and updates related type definitions.
Changes:
- Migrated burgs-generator module from JavaScript to TypeScript with proper type definitions
- Added Burg interface export and updated PackedGraph type definitions
- Extended global type declarations for burgs-related functionality
- Removed legacy JavaScript script tag from index.html
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/burgs-generator.ts | New TypeScript implementation of the burgs generator module with BurgModule class and Burg interface |
| src/types/global.ts | Added global declarations for burgs-related variables and functions (options, Routes, population settings, drawing functions, etc.) |
| src/types/PackedGraph.ts | Added Burg type import and extended cells interface with burg, religion, state properties; added burgs and states arrays |
| src/modules/index.ts | Added import for new burgs-generator module |
| src/index.html | Removed legacy script tag for old JavaScript burgs-generator module |
| public/modules/burgs-generator.js | Deleted old JavaScript implementation (complete file removal) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Versioning