refactor: migrate markers#1324
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the markers generator module from vanilla JavaScript to TypeScript. The markers generator is responsible for creating various point-of-interest markers on the fantasy map (volcanoes, hot springs, inns, dungeons, etc.).
Changes:
- Migrated
public/modules/markers-generator.jstosrc/modules/markers-generator.tswith proper TypeScript types - Removed the old JavaScript file and its script tag from
index.html - Added the new TypeScript module to the module index at
src/modules/index.ts - Updated global type declarations in
src/types/global.tsto includeheightUnit,changeFont, andgetFriendlyHeight
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/markers-generator.ts | New TypeScript version of markers generator with class-based structure, proper type definitions (MarkerConfig, Marker), and improved type safety |
| src/modules/index.ts | Added import for the new markers-generator module |
| src/index.html | Removed script tag for old JavaScript markers-generator module |
| src/types/global.ts | Added global type declarations for heightUnit, changeFont, and getFriendlyHeight functions used by the markers module |
| public/modules/markers-generator.js | Deleted - replaced by TypeScript version |
Owner
|
I see a log of spelling issue, please fix them as well :) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
All done @Azgaar |
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Versioning