Fix: Military regiment notes not updated on regeneration with new era/year

[Copilot]

Regiment notes retained stale era/year text after changing Options and recalculating military, because generateNote() always appended to notes[] without removing the prior entry — and notes.find() returns the first match.

Description

Changes in public/modules/military-generator.js:

• generateNote(): If a note with the matching ID already exists, update it in-place (name and legend fields). Only push a new entry when no existing note is found. The update-in-place path is intentionally kept since generateNote is also called from outside this module.
• generate(): Before regenerating regiments for any state, remove all existing regiment notes in a single upfront pass (notes whose ID starts with "regiment"). This is simpler and more correct than removing per-state, since all regiments are always fully regenerated together.

// generateNote — update in-place if note already exists
const existing = notes.find(n => n.id === id);
if (existing) {
  existing.name = r.name;
  existing.legend = legend;
} else {
  notes.push({id, name: r.name, legend});
}

// generate — remove all regiment notes in one pass before rebuild
for (let i = notes.length - 1; i >= 0; i--) {
  if (notes[i].id.startsWith("regiment")) notes.splice(i, 1);
}

Type of change

• Bug fix
• New feature
• Refactoring / style
• Documentation update / chore
• Other (please describe)

Versioning

• Version is updated
• Changed files hash is updated

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Military notes are not updated on regiment or Era data change</issue_title>
<issue_description>I'm regenerating my military/regiment layer, but it's regenerating the numbers but not the write-ups. It's keeping the old Year and Era info that I've since changed in the Options tab. Is there a way to update this?

My military regiments aren't updating their descriptions and are still using the old era that was randomly generated, even when I regen military. </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Military notes are not updated on regiment or Era data change #1328

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[netlify]

✅ Deploy Preview for afmg ready!

Name	Link
🔨 Latest commit	ccdbeb7
🔍 Latest deploy log	https://app.netlify.com/projects/afmg/deploys/699740ca143d6e0008bdc3af
😎 Deploy Preview	https://deploy-preview-1329--afmg.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Copilot]

Pull request overview

This PR fixes a bug where military regiment notes retained stale era/year information after changing Options and regenerating military forces. The issue occurred because generateNote() always appended new notes without removing prior entries, and notes.find() would return the first (stale) match.

Changes:

• Modified generate() to remove all existing regiment notes upfront before regeneration
• Updated generateNote() to support updating existing notes in-place (though this becomes dead code given the upfront removal)

[Azgaar]

@copilot, please update the version.

[Copilot]

@copilot, please update the version.

Done in ccdbeb7 — bumped VERSION to 1.112.3 in public/versioning.js and updated the military-generator.js cache-buster query string in src/index.html to match.