Skip to content

Fix: add getPin function and improve code formatting in draw-markers#1349

Merged
Azgaar merged 2 commits intomasterfrom
fix-getPin
Mar 7, 2026
Merged

Fix: add getPin function and improve code formatting in draw-markers#1349
Azgaar merged 2 commits intomasterfrom
fix-getPin

Conversation

@Azgaar
Copy link
Copy Markdown
Owner

@Azgaar Azgaar commented Mar 7, 2026

Description

Type of change

  • Bug fix
  • New feature
  • Refactoring / style
  • Documentation update / chore
  • Other (please describe)

Versioning

  • Version is updated
  • Changed files hash is updated

@Azgaar Azgaar self-assigned this Mar 7, 2026
Copilot AI review requested due to automatic review settings March 7, 2026 17:19
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 7, 2026

Deploy Preview for afmg ready!

Name Link
🔨 Latest commit df56e18
🔍 Latest deploy log https://app.netlify.com/projects/afmg/deploys/69ac5e93c8f1100008674e81
😎 Deploy Preview https://deploy-preview-1349--afmg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the marker rendering code to expose a reusable getPin helper globally (so other modules can render marker pins consistently) and applies some formatting/refactoring changes in the marker renderer.

Changes:

  • Expose getPin(shape, fill, stroke) on window and add its global type declaration.
  • Refactor marker destructuring and markers list rendering into more compact expressions.
  • Apply formatting changes in draw-markers.ts.
Comments suppressed due to low confidence (4)

src/renderers/draw-markers.ts:1

  • import {rn} is not Biome-formatted (the repo’s CI runs biome ci .). Please run npm run format / biome format and commit the formatting output so CI doesn’t fail on spacing inside import braces.
import { rn } from "../utils";

src/renderers/draw-markers.ts:25

  • type PinShapes = {[key: string]: PinShapeFunction}; isn’t Biome-formatted (spacing inside braces). Since CI enforces Biome formatting, please reformat this type (e.g., run npm run format) and commit the result.
type PinShapes = { [key: string]: PinShapeFunction };

src/renderers/draw-markers.ts:62

  • This destructuring assignment was collapsed into a very long single line and is likely to be re-wrapped by Biome, which would cause biome ci to fail. Please apply the Biome formatter (or manually re-wrap) and commit the formatted output.
  const {

src/renderers/draw-markers.ts:85

  • markersData.map(marker => ...) is not consistent with Biome formatting used elsewhere in src/**/*.ts (and may be rewritten by the formatter), which can fail biome ci. Please reformat this callback to match the repository’s standard arrow-function style.
      <text x="${dx}%" y="${dy}%" font-size="${px}px" >${isExternal ? "" : icon}</text>

@Azgaar Azgaar merged commit afe89ef into master Mar 7, 2026
6 of 8 checks passed
@Azgaar Azgaar deleted the fix-getPin branch March 7, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants