Skip to content

Minor fixes#1388

Merged
Azgaar merged 6 commits intomasterfrom
minor-fixes
Apr 24, 2026
Merged

Minor fixes#1388
Azgaar merged 6 commits intomasterfrom
minor-fixes

Conversation

@Azgaar
Copy link
Copy Markdown
Owner

@Azgaar Azgaar commented Apr 24, 2026

Description

Azgaar and others added 5 commits April 24, 2026 14:24
…eout syntax in world configurator

Co-authored-by: Copilot <copilot@github.com>
…and versioning modules

Co-authored-by: Copilot <copilot@github.com>
…oad functions

Co-authored-by: Copilot <copilot@github.com>
@Azgaar Azgaar self-assigned this Apr 24, 2026
Copilot AI review requested due to automatic review settings April 24, 2026 13:06
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for afmg ready!

Name Link
🔨 Latest commit fc7f56b
🔍 Latest deploy log https://app.netlify.com/projects/afmg/deploys/69eb6d6dfe7f6e0007ccd1f8
😎 Deploy Preview https://deploy-preview-1388--afmg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

A collection of small fixes and cleanups across rendering, UI, and IO flows (including improved tree-shaking in the heightmap renderer, safer exports, and clearer user-facing messages).

Changes:

  • Refactor draw-heightmap to avoid d3 namespace access and use an explicit curve map for better tree-shaking.
  • Improve robustness/UX of IO flows (save/load/export): better error messages, async handling, autosave feedback, URL-load timeout handling.
  • Miscellaneous polish: optional chaining cleanup, typo fixes, formatting/readability improvements, and removal of outdated UI text.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/utils/commonUtils.ts Formatting tweak to the global Window.clipPoly type signature.
src/renderers/draw-heightmap.ts Replace d3 namespace usage with explicit curve imports and a curve lookup map to aid tree-shaking.
src/modules/states-generator.ts Remove an outdated TODO comment.
src/modules/provinces-generator.ts Use dot access (forms.Wild) instead of bracket access for consistency.
src/modules/military-generator.ts Use optional chaining in an overlap check for readability.
src/modules/emblem/generator.ts Improve Biome ignore comments with a real explanation.
src/index.html Remove a paragraph referencing Foundry VTT export/module.
public/versioning.js Fix “Worldbuilding” typo; fix compact version parsing logic by avoiding overwriting before slicing patch.
public/modules/ui/world-configurator.js Fix setTimeout to defer ThreeD.update instead of calling it immediately.
public/modules/ui/options.js Avoid infinite polling for speech voices; add fallback option when none are available.
public/modules/ui/heightmap-editor.js Readability formatting and improved confirmation text for closing Image Converter.
public/modules/ui/general.js Debounce tooltip mousemove handlers to reduce event spam; minor formatting.
public/modules/ui/ai-generator.js Improve error parsing logging and make UI error messaging more resilient.
public/modules/io/save.js Await async save targets, improve error strings, defer object URL revocation, add autosave failure tip, remove unused gzip compress helper.
public/modules/io/load.js Convert URL-loading to async/await, add timeout via AbortController, improve error messaging, fix loading error text.
public/modules/io/export.js Add try/catch and better error reporting for exports; rework PNG/JPEG export to promise-based image load + toBlob; add error handling for tiles zip creation.

Comment thread src/renderers/draw-heightmap.ts Outdated
Comment thread public/modules/io/load.js Outdated
Comment thread public/modules/io/load.js
…error message handling

Co-authored-by: Copilot <copilot@github.com>
@Azgaar Azgaar merged commit beb4f52 into master Apr 24, 2026
8 checks passed
@Azgaar Azgaar deleted the minor-fixes branch April 24, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants