Fix broken 'North Sea Region' heightmap preset (restore Europe North)#1529
Merged
Merged
Conversation
The id-11 precreated heightmap key was renamed from "europe-north" to "north-sea-region" in Azgaar#1493, but the image file stayed europe-north.png. Both the selector thumbnail and map generation request ./heightmaps/north-sea-region.png (via ./heightmaps/${id}.png), which does not exist, so the preset shows a broken image and fails to generate. Restore the "Europe North" name/key and swap in a heightmap that covers northern Europe (Scandinavia + Iceland), which also fixes the broken image path.
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1493 renamed the id-11 precreated heightmap key from
europe-northtonorth-sea-region(and updateddefineMapSize), but the image file was left aspublic/heightmaps/europe-north.png. Since both the selector thumbnail and map generation load the image via./heightmaps/${id}.png, the preset now requests the non-existent./heightmaps/north-sea-region.png— so it renders a broken image in the selector and cannot generate.This restores the
europe-northkey / Europe North name (matching the existing image filename) and replaces the image with a heightmap that actually covers northern Europe (Scandinavia + Iceland), rather than the previous UK/North-Sea-centric one. That resolves the naming discussion behind #1493 while fixing the broken image path in one change.Changes
public/config/precreated-heightmaps.js—north-sea-region→europe-north(name "Europe North")public/main.js—defineMapSize()template check updated toeurope-northpublic/heightmaps/europe-north.png— new northern-Europe heightmap (Scandinavia + Iceland)Testing
Generated a map from the preset: landmasses fill the frame correctly (Scandinavia, Iceland, Britain) and the climate gradient (arctic north → temperate south) matches the region.