Skip to content

Commit 68662f4

Browse files
committed
Update README.md
1 parent 43e714f commit 68662f4

1 file changed

Lines changed: 29 additions & 1 deletion

File tree

README.md

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,35 @@ The node now supports outputs up to 32K resolution. When working with very high
289289

290290
✅ Temporary Fix: Disable or uninstall `comfyui-mixlab-nodes` – the node will then display and work correctly.
291291
❌ Unfortunately, I cannot reproduce this bug on my end, since with my setup both node packs work fine together.
292-
Until a proper fix is found, the only workaround is disabling `comfyui-mixlab-nodes`.
292+
👉 Until a proper fix is implemented in `comfyui-mixlab-nodes`, the only workaround is disabling `comfyui-mixlab-nodes` or manual patch (see below).
293+
294+
<details>
295+
<summary>🔧 Advanced explanation and manual patch (click to expand)</summary>
296+
297+
If you *really* want or need to use comfyui-mixlab-nodes despite this, here’s the deal:
298+
299+
The problem occurs because **mixlab overrides the `onDrawForeground` method of other nodes**, which breaks their display. This behavior is, frankly, unacceptable since it hijacks a method other nodes legitimately rely on. The good news is that mixlab only uses this override if the method is defined in the prototype, which means we can adjust it safely.
300+
301+
### ✅ Patch
302+
In `ui_mixlab.js` (see [source line here](https://github.com/shadowcz007/comfyui-mixlab-nodes/blob/67c974c96e6472316cb4bf4326281d9f86a25ae6/web/javascript/ui_mixlab.js#L2186C11-L2186C55)), replace this part:
303+
304+
```js
305+
const orig = node.__proto__.onDrawForeground;
306+
```
307+
308+
with this safer version:
309+
310+
```js
311+
const orig = node.onDrawForeground ?? node.__proto__.onDrawForeground;
312+
```
313+
314+
With this modification, the Resolution Master node (and potentially other affected nodes) will render correctly again.
315+
You can either apply this tweak manually or report it to the mixlab authors so it can be properly integrated upstream.
316+
317+
📌 Full discussion and context are available here:
318+
[github.com/Smirnov75/ComfyUI-mxToolkit/issues/28#issuecomment-2603091317](https://github.com/Smirnov75/ComfyUI-mxToolkit/issues/28#issuecomment-2603091317)
319+
320+
</details>
293321

294322

295323
## Contributing

0 commit comments

Comments
 (0)