chore(docs): bugfix + deploy on master (#13717)

# Automatically release docs on master branch

This PR adds automatic documentation release when changes are merged to
the master branch. It:

- Updates the main bootstrap.sh to call release-docs when on the master
branch
- Renames the docs release command from "release" to "release-docs" to
avoid it running on releases (we don't need it)
- Passes CI parameter to project bootstrap scripts in the release
workflow to avoid the yarn lock problem
- Removes stderr redirection in docs deployment so we can see the output
of the release in the logs
- Removes the deploy-doc github-action since that will be dealt with on
the `ci`

The changes ensure our documentation is automatically deployed whenever
changes are merged to master, improving our documentation workflow.

---------

Co-authored-by: Maddiaa <47148561+Maddiaa0@users.noreply.github.com>

Author: signorecello

.github/workflows/docs-deploy.yml .github/workflows/docs-typesense.yml.github/workflows/docs-deploy.yml renamed to .github/workflows/docs-typesense.yml

@@ -1,4 +1,4 @@
-name: Docs Deploy
+name: Docs Scraper
 
 on:
   workflow_dispatch:
@@ -9,7 +9,7 @@ on:
       - docs/**
 
 jobs:
-  docs-pr:
+  docs-scraper:
     runs-on: ubuntu-latest
     env:
       AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
@@ -23,30 +23,6 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Set up Node.js
-        uses: actions/setup-node@v3
-        with:
-          node-version: "18"
-
-      - name: Enable Corepack
-        run: corepack enable
-
-      - name: Configure Git
-        run: |
-          git config --global user.name AztecBot
-          git config --global user.email tech@aztecprotocol.com
-
-      - name: Build dependencies
-        run: |
-          for project in noir barretenberg l1-contracts yarn-project; do
-            $project/bootstrap.sh
-          done
-
-      # Making the bash script here so we don't accidentally deploy
-      - name: Deploy docs
-        run: |
-          ./docs/bootstrap.sh release
-
       - name: Reindex with Typesense docsearch-scraper
         run: |
           docker run \

.github/workflows/release-please.yml

@@ -54,7 +54,7 @@ jobs:
       - name: Build dependencies
         run: |
           for project in noir barretenberg l1-contracts yarn-project; do
-            $project/bootstrap.sh
+            CI=1 $project/bootstrap.sh
           done
 
       - name: Query new version

bootstrap.sh

@@ -341,6 +341,10 @@ case "$cmd" in
         echo_stderr -e "${yellow}Not testing or benching $REF_NAME because it is a release tag.${reset}"
       fi
     fi
+
+    if [ "$REF_NAME" = "master" ]; then
+      docs/bootstrap.sh release-docs
+    fi
     ;;
   test|test_cmds|bench|release|release_dryrun)
     $cmd "$@"

docs/bootstrap.sh

@@ -37,11 +37,7 @@ function release_docs {
   yarn install
   yarn build
 
-  if ! deploy_output=$(yarn netlify deploy --site aztec-docs-dev --prod 2>&1); then
-    echo "Netlify deploy failed with error:"
-    echo "$deploy_output"
-    exit 1
-  fi
+  yarn netlify deploy --site aztec-docs-dev --prod 2>&1
 }
 
 case "$cmd" in
@@ -54,7 +50,7 @@ case "$cmd" in
   "hash")
     echo "$hash"
     ;;
-  "release")
+  "release-docs")
     release_docs
     ;;
   *)