chore(fast-inbox): remove legacy inHash and per-checkpoint index helpers from stdlib/p2p (A-1388)

Deletes computeInHashFromL1ToL2Messages and the inHash field from BlockProposal
(including its signed-payload slot), the CheckpointProposal getBlockProposal
pass-through, and the createBlockProposal inHash argument on the validator
interface. Removes the padded per-checkpoint InboxLeaf helpers
(smallestIndexForCheckpoint / indexRangeForCheckpoint / checkpointNumberFromIndex)
and the legacy getL1ToL2Messages(checkpointNumber) member from the L1ToL2MessageSource
and archiver RPC interfaces. Regenerates the block-proposal golden wire fixtures for
the shrunk payload; the p2p wire format changes at a release boundary (fresh networks),
matching the A-1381 optional-tail precedent.

Author: spalladino

yarn-project/p2p/src/services/libp2p/libp2p_service.test.ts

@@ -20,7 +20,7 @@ import {
   makeCheckpointProposal,
   mockTx,
 } from '@aztec/stdlib/testing';
-import { TxArray, TxHashArray } from '@aztec/stdlib/tx';
+import { TxArray, TxHash, TxHashArray } from '@aztec/stdlib/tx';
 import { type TelemetryClient, getTelemetryClient } from '@aztec/telemetry-client';
 import { ServerWorldStateSynchronizer } from '@aztec/world-state';
 
@@ -809,8 +809,8 @@ describe('LibP2PService', () => {
     });
 
     // Regression for A-1013: payloads sharing (slot, position, archive) but differing on another
-    // signed field (e.g. inHash) used to dedup by archive only and silently drop the second one.
-    // The pool now dedups by signed-payload hash, so the equivocation surfaces.
+    // signed field (e.g. the transaction set) used to dedup by archive only and silently drop the
+    // second one. The pool now dedups by signed-payload hash, so the equivocation surfaces.
     it('same archive but different signed payload triggers slash callback', async () => {
       const blockHeader = makeBlockHeader(1, { slotNumber: targetSlot });
       const indexWithinCheckpoint = IndexWithinCheckpoint(0);
@@ -820,7 +820,7 @@ describe('LibP2PService', () => {
         signer,
         blockHeader,
         indexWithinCheckpoint,
-        inHash: Fr.fromString('0x1'),
+        txHashes: [TxHash.fromField(new Fr(1))],
         archiveRoot: sharedArchive,
       });
       await service.processBlockFromPeer(proposal1.toBuffer(), 'msg-1', mockPeerId);
@@ -830,7 +830,7 @@ describe('LibP2PService', () => {
         signer,
         blockHeader,
         indexWithinCheckpoint,
-        inHash: Fr.fromString('0x2'),
+        txHashes: [TxHash.fromField(new Fr(2))],
         archiveRoot: sharedArchive,
       });
       expect(proposal2.archive.toString()).toBe(proposal1.archive.toString());

yarn-project/stdlib/src/block/l2_block.ts

@@ -155,7 +155,6 @@ export class L2Block {
    * @param txsPerBlock - The number of transactions to include in the block.
    * @param numPublicCallsPerTx - The number of public function calls to include in each transaction.
    * @param numPublicLogsPerCall - The number of public logs per 1 public function invocation.
-   * @param inHash - The hash of the L1 to L2 messages subtree which got inserted in this block.
    * @returns The L2 block.
    */
   static async random(

yarn-project/stdlib/src/interfaces/archiver.test.ts

@@ -204,11 +204,6 @@ describe('ArchiverApiSchema', () => {
     expect(result).toEqual([expect.any(Fr)]);
   });
 
-  it('getL1ToL2Messages', async () => {
-    const result = await context.client.getL1ToL2Messages(CheckpointNumber(1));
-    expect(result).toEqual([expect.any(Fr)]);
-  });
-
   it('getL1ToL2MessageIndex', async () => {
     const result = await context.client.getL1ToL2MessageIndex(Fr.random());
     expect(result).toBe(1n);
@@ -564,10 +559,6 @@ class MockArchiver implements ArchiverApi {
     expect(Array.isArray(signatures)).toBe(true);
     return Promise.resolve();
   }
-  getL1ToL2Messages(checkpointNumber: CheckpointNumber): Promise<Fr[]> {
-    expect(checkpointNumber).toEqual(CheckpointNumber(1));
-    return Promise.resolve([Fr.random()]);
-  }
   getL1ToL2MessageIndex(l1ToL2Message: Fr): Promise<bigint | undefined> {
     expect(l1ToL2Message).toBeInstanceOf(Fr);
     return Promise.resolve(1n);

yarn-project/stdlib/src/interfaces/archiver.ts

@@ -128,7 +128,6 @@ export const ArchiverApiSchema: ApiSchemaFor<ArchiverApi> = {
   }),
   getContractClassIds: z.function({ input: z.tuple([]), output: z.array(schemas.Fr) }),
   registerContractFunctionSignatures: z.function({ input: z.tuple([z.array(z.string())]), output: z.void() }),
-  getL1ToL2Messages: z.function({ input: z.tuple([CheckpointNumberSchema]), output: z.array(schemas.Fr) }),
   getL1ToL2MessageIndex: z.function({ input: z.tuple([schemas.Fr]), output: schemas.BigInt.optional() }),
   getLatestInboxBucketAtOrBefore: z.function({
     input: z.tuple([schemas.BigInt]),

yarn-project/stdlib/src/interfaces/validator.ts

@@ -153,7 +153,6 @@ export interface Validator {
     blockHeader: BlockHeader,
     checkpointNumber: CheckpointNumber,
     indexWithinCheckpoint: number,
-    inHash: Fr,
     archive: Fr,
     txs: Tx[],
     proposerAddress: EthAddress | undefined,

yarn-project/stdlib/src/messaging/in_hash.ts

@@ -1,6 +1,4 @@
-import { INITIAL_CHECKPOINT_NUMBER, MAX_L1_TO_L2_MSGS_PER_CHECKPOINT } from '@aztec/constants';
 import { toBigIntBE } from '@aztec/foundation/bigint-buffer';
-import { CheckpointNumber } from '@aztec/foundation/branded-types';
 import { Fr } from '@aztec/foundation/curves/bn254';
 import { BufferReader, serializeToBuffer } from '@aztec/foundation/serialize';
 
@@ -22,23 +20,4 @@ export class InboxLeaf {
     const leaf = reader.readObject(Fr);
     return new InboxLeaf(index, leaf);
   }
-
-  static smallestIndexForCheckpoint(checkpointNumber: CheckpointNumber): bigint {
-    return BigInt(checkpointNumber - INITIAL_CHECKPOINT_NUMBER) * BigInt(MAX_L1_TO_L2_MSGS_PER_CHECKPOINT);
-  }
-
-  /**
-   * Returns the range of valid indices for a given checkpoint.
-   * Start index is inclusive, end index is exclusive.
-   */
-  static indexRangeForCheckpoint(checkpointNumber: CheckpointNumber): [bigint, bigint] {
-    const start = this.smallestIndexForCheckpoint(checkpointNumber);
-    const end = start + BigInt(MAX_L1_TO_L2_MSGS_PER_CHECKPOINT);
-    return [start, end];
-  }
-
-  /** Returns the checkpoint number for a given leaf index */
-  static checkpointNumberFromIndex(index: bigint): CheckpointNumber {
-    return CheckpointNumber(Number(index / BigInt(MAX_L1_TO_L2_MSGS_PER_CHECKPOINT)) + INITIAL_CHECKPOINT_NUMBER);
-  }
 }

yarn-project/stdlib/src/messaging/inbox_leaf.ts

@@ -1,5 +1,4 @@
 export * from './append_l1_to_l2_messages.js';
-export * from './in_hash.js';
 export * from './inbox_bucket.js';
 export * from './inbox_consumption.js';
 export * from './inbox_leaf.js';

yarn-project/stdlib/src/messaging/index.ts

@@ -1,4 +1,3 @@
-import type { CheckpointNumber } from '@aztec/foundation/branded-types';
 import type { Fr } from '@aztec/foundation/curves/bn254';
 
 import type { L2Tips } from '../block/l2_block_source.js';
@@ -8,15 +7,6 @@ import type { InboxBucket } from './inbox_bucket.js';
  * Interface of classes allowing for the retrieval of L1 to L2 messages.
  */
 export interface L1ToL2MessageSource {
-  /**
-   * Gets new L1 to L2 message (to be) included in a given checkpoint.
-   * @param checkpointNumber - Checkpoint number to get messages for.
-   * @returns The L1 to L2 messages/leaves of the messages subtree.
-   * @throws If the message tree for the given checkpoint has not yet been sealed on L1
-   * (i.e., checkpointNumber >= inbox treeInProgress).
-   */
-  getL1ToL2Messages(checkpointNumber: CheckpointNumber): Promise<Fr[]>;
-
   /**
    * Gets the L1 to L2 message index in the L1 to L2 message tree.
    * @param l1ToL2Message - The L1 to L2 message.

yarn-project/stdlib/src/messaging/l1_to_l2_message_source.ts

@@ -23,7 +23,6 @@ const makeLegacyFixtureProposal = () =>
   new BlockProposal(
     BlockHeader.empty(),
     IndexWithinCheckpoint(3),
-    new Fr(42n),
     new Fr(99n),
     [TxHash.fromField(new Fr(7n)), TxHash.fromField(new Fr(8n))],
     Signature.empty(),
@@ -105,7 +104,6 @@ describe('Block Proposal serialization / deserialization', () => {
     const tampered = new BlockProposal(
       proposal.blockHeader,
       proposal.indexWithinCheckpoint,
-      proposal.inHash,
       proposal.archiveRoot,
       proposal.txHashes,
       proposal.signature,
@@ -161,7 +159,6 @@ describe('Block Proposal serialization / deserialization', () => {
       const withoutRef = await makeBlockProposal({
         blockHeader: withRef.blockHeader,
         indexWithinCheckpoint: withRef.indexWithinCheckpoint,
-        inHash: withRef.inHash,
         archiveRoot: withRef.archiveRoot,
         txHashes: withRef.txHashes,
       });
@@ -195,7 +192,6 @@ describe('Block Proposal serialization / deserialization', () => {
       const tampered = new BlockProposal(
         proposal.blockHeader,
         proposal.indexWithinCheckpoint,
-        proposal.inHash,
         proposal.archiveRoot,
         proposal.txHashes,
         proposal.signature,
@@ -215,7 +211,6 @@ describe('Block Proposal serialization / deserialization', () => {
       const injected = new BlockProposal(
         proposal.blockHeader,
         proposal.indexWithinCheckpoint,
-        proposal.inHash,
         proposal.archiveRoot,
         proposal.txHashes,
         proposal.signature,