chore: correct stale bb-dependency comments in lmdblib/kvdb CMake

These packages were made barretenberg-free, but the lmdblib CMake header still
claimed it depended on bb headers (db_stats.hpp) and that consumers link
libbarretenberg.a — contradicting a later comment in the same file. The
Release-default comments likewise cited a 'compile bb headers' ODR rationale
that no longer applies. Correct both to the real reason: the Release default
keeps lmdblib's own templated/inline headers' codegen identical between
liblmdblib.a and the consumers that include them (kvdb .node, wsdb).

Author: charlielye

native-packages/kvdb/cpp/CMakeLists.txt

@@ -14,8 +14,9 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
 
-# Match barretenberg's prebuilt archive (Release -> -O3 -DNDEBUG): bb headers compiled
-# here must use the same NDEBUG/opt as bb to avoid ODR-divergent inlined code.
+# Default to Release (-O3 -DNDEBUG) to match the prebuilt liblmdblib.a it links: the
+# shared lmdblib templated/inline headers must be compiled the same way in both, or
+# their inline codegen diverges (ODR).
 if(NOT CMAKE_BUILD_TYPE)
     set(CMAKE_BUILD_TYPE Release)
 endif()

native-packages/lmdblib/cpp/CMakeLists.txt

@@ -6,9 +6,9 @@
 #   - liblmdb.a    : the upstream LMDB C library (pinned to bb's commit)
 #   - liblmdblib.a : the bb::lmdblib C++ wrapper objects
 #
-# It depends on barretenberg only for *headers* (serialize, common, numeric, and
-# crypto/merkle_tree/db_stats.hpp for the shared DBStats type). The wrapper's
-# unresolved bb symbols are satisfied when a consumer links libbarretenberg.a.
+# It is barretenberg-free: it includes no bb headers and links no bb archives. It
+# vendors its own msgpack-c + lmdb (commits pinned to barretenberg/cpp/cmake/*) and
+# defines the shared DBStats POD locally (src/lmdblib/types.hpp).
 
 cmake_minimum_required(VERSION 3.24)
 # C is enabled so CMAKE_C_COMPILER is populated for lmdb's ExternalProject build.
@@ -19,8 +19,10 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
 
-# Match barretenberg's prebuilt archive (Release -> -O3 -DNDEBUG): bb headers compiled
-# here must use the same NDEBUG/opt as bb to avoid ODR-divergent inlined code.
+# Default to Release (-O3 -DNDEBUG). lmdblib's templated/inline headers (serialise_key,
+# value_cmp, the msgpack adaptors) are compiled into both liblmdblib.a and into every
+# consumer that includes them (the kvdb .node, the wsdb service). Matching the consumers'
+# Release build keeps that inline codegen identical and avoids ODR divergence.
 if(NOT CMAKE_BUILD_TYPE)
     set(CMAKE_BUILD_TYPE Release)
 endif()