chore: remove orphan --archiver flag usages from start invocations (#23186)

## Motivation

The top-level `--archiver` flag was removed from `aztec start`, but
several scripts, Helm/Terraform values, and docs still pass it. Leaving
these in place would break node and prover startup once they pick up the
new CLI.

## Approach

Grepped the repo for bare `--archiver` (excluding nested
`--archiver.<option>` flags, which are still valid) and removed every
occurrence from start commands, docs, and the bot CLI handler. Also
dropped the now-stale check for an `archiver` option in `start_bot.ts`
and a stray comment in `aztec_start_options.ts`.

## Changes

- **docker-compose.yml**: drop `--archiver` from the node entrypoint
- **spartan (helm + terraform values)**: remove `--archiver` from
`aztec-node`, `aztec-validator`, `aztec-prover-stack`, and the
`full-node`, `rpc`, `archive`, `blob-sink` terraform values; update
`aztec-node/README.md` examples and options table
- **yarn-project/aztec**: drop `archiver` from the unsupported-flags
check in `start_bot.ts`; remove stale comment in
`aztec_start_options.ts`
- **docs/docs-operate**: drop `--archiver` from the
node/prover/sequencer setup, troubleshooting, and CLI reference pages;
reword the reference prose to use `--archiver.blobSinkUrl` as the
example

Versioned snapshots under `docs/network_versioned_docs/version-v4.2.0/`
are intentionally left untouched.

Author: spalladino

docker-compose.yml

@@ -54,7 +54,7 @@ services:
           fi;
         done;
 
-        node /usr/src/yarn-project/aztec/dest/bin/index.js start --node --archiver
+        node /usr/src/yarn-project/aztec/dest/bin/index.js start --node
       '
     volumes:
       - aztec:/var/lib/aztec

docs/docs-operate/operators/monitoring/troubleshooting.md

@@ -35,7 +35,6 @@ services:
       /usr/src/yarn-project/aztec/dest/bin/index.js
       start
       --node
-      --archiver
       --network #release_network
     networks:
       - aztec

docs/docs-operate/operators/reference/cli-reference.md

@@ -26,7 +26,7 @@ tags:
 **Configuration notes:**
 
 - The environment variable name corresponding to each flag is shown as $ENV_VAR on the right hand side.
-- If two subsystems can contain the same configuration option, only one needs to be provided. For example, `--archiver.blobSinkUrl` and `--sequencer.blobSinkUrl` point to the same value if the node is started with both the `--archiver` and `--sequencer` options.
+- If two subsystems can contain the same configuration option, only one needs to be provided. For example, `--archiver.blobSinkUrl` and `--sequencer.blobSinkUrl` point to the same value.
 
 ```bash
   MISC
@@ -119,9 +119,6 @@ tags:
 
   ARCHIVER
 
-    --archiver
-          Starts Aztec Archiver with options
-
     --archiver.blobSinkUrl <value>                                                                                                         ($BLOB_SINK_URL)
           The URL of the blob sink
 

docs/docs-operate/operators/setup/running-a-node.md

@@ -96,7 +96,6 @@ services:
       /usr/src/yarn-project/aztec/dest/bin/index.js
       start
       --node
-      --archiver
       --network #release_network
     networks:
       - aztec

docs/docs-operate/operators/setup/running-a-prover.md

@@ -155,7 +155,6 @@ services:
       /usr/src/yarn-project/aztec/dest/bin/index.js
       start
       --prover-node
-      --archiver
       --network #release_network
     depends_on:
       prover-broker:

docs/docs-operate/operators/setup/sequencer-setup.md

@@ -410,7 +410,6 @@ services:
       /usr/src/yarn-project/aztec/dest/bin/index.js
       start
       --node
-      --archiver
       --sequencer
       --network #release_network
     networks:

spartan/aztec-node/README.md

@@ -40,7 +40,6 @@ node:
 
   startCmd:
     - --node
-    - --archiver
 
   startupProbe:
     # -- Period seconds
@@ -91,7 +90,6 @@ node:
 
   startCmd:
     - --node
-    - --archiver
     - --sequencer
 
   startupProbe:
@@ -144,7 +142,7 @@ service:
 | node.l1ConsensusUrls | [] | L1 consensus host URLs (comma-separated list) |
 | node.l1ConsensusHostApiKeys | [] | API keys for L1 consensus hosts |
 | node.l1ConsensusHostApiKeyHeaders | [] | API key headers for L1 consensus hosts |
-| node.startCmd | ["--node", "--archiver"] | Startup command for the node |
+| node.startCmd | ["--node"] | Startup command for the node |
 | node.remoteUrl.archiver | - | Remote URL for archiver |
 | node.remoteUrl.proverBroker | - | Remote URL for prover broker |
 | node.remoteUrl.proverCoordinationNodes | [] | Remote URLs for prover coordination nodes |

spartan/aztec-node/values.yaml

@@ -78,7 +78,6 @@ node:
 
   startCmd:
     - --node
-    - --archiver
 
   image:
     repository: ""

spartan/aztec-prover-stack/values.yaml

@@ -39,7 +39,6 @@ node:
 
     startCmd:
       - --prover-node
-      - --archiver
 
     configMap:
       envEnabled: true

spartan/aztec-validator/values.yaml

@@ -40,7 +40,6 @@ validator:
 
     startCmd:
       - --node
-      - --archiver
       - --sequencer
 
   web3signerUrl: ""