Skip to content

Commit 2a3e928

Browse files
authored
feat(ci): notify #team-fairies when backwards-compat e2e fails on nightly (#23003)
## Summary `ci-compat-e2e` is `continue-on-error: true` on nightly tags (see `.github/workflows/ci3.yml` line 316), so when it fails the workflow stays green and nobody finds out unless they manually open the run. Today's nightly compat failure (contract-artifacts) is the surfacing case. Wraps `bootstrap_ec2 "./bootstrap.sh ci-compat-e2e"` in `ci.sh` so that on a `-nightly.` tag a failing run posts to `#team-fairies` via the existing `ci3/slack_notify` helper, then exits with the captured rc (so GH job result is unchanged). Stable/RC tags already block the release pipeline on this job and PR-label runs are interactive, so the notification is intentionally limited to nightlies. ## Targeting PR targets `v4-next` because `ci-compat-e2e` only lives on `v4-next` (not on `next`). ## Notes A workflow-level step (`if: failure() && contains(github.ref_name, '-nightly.')` in the `ci-compat-e2e` job) would be slightly more idiomatic and mirror the existing "Notify Slack on backport CI failure" step at lines 116-130. This session was started without `ci-allow`, so `.github/workflows/ci3.yml` is off-limits to `create_pr`; the `ci.sh`-level change is functionally equivalent. An exact workflow-level patch is documented in https://gist.github.com/AztecBot/1004e4a07b57807329b334b043c17d12 in case the team prefers to apply it that way later. Closes [F-632](https://linear.app/aztec-labs/issue/F-632/notify-team-fairies-channel-when-backwards-compat-fails). ClaudeBox log: https://claudebox.work/s/a0aa5c1e0994ac85?run=1
2 parents 6ca1031 + 866ca2e commit 2a3e928

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

ci.sh

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,15 @@ case "$cmd" in
265265
export CI_DASHBOARD="releases"
266266
export JOB_ID="x-compat-e2e"
267267
export AWS_SHUTDOWN_TIME=300
268-
bootstrap_ec2 "./bootstrap.sh ci-compat-e2e"
268+
rc=0
269+
bootstrap_ec2 "./bootstrap.sh ci-compat-e2e" || rc=$?
270+
# On nightly tags compat-e2e is non-blocking (continue-on-error in ci3.yml), so
271+
# failures otherwise go unnoticed. Notify #team-fairies so they get picked up.
272+
if [ "$rc" -ne 0 ] && [[ "${REF_NAME:-}" == *-nightly.* ]]; then
273+
run_url="https://github.com/${GITHUB_REPOSITORY:-AztecProtocol/aztec-packages}/actions/runs/${GITHUB_RUN_ID:-unknown}"
274+
"$ci3/slack_notify" "Backwards compatibility e2e tests FAILED on nightly tag <${run_url}|${REF_NAME}>" "#team-fairies"
275+
fi
276+
exit "$rc"
269277
;;
270278

271279
############

0 commit comments

Comments
 (0)