Skip to content

Commit 36fb411

Browse files
authored
chore(ci): scenario tests pick docker registry by repo on v5-next (#24022)
## What In `ci3.yml`'s `ci-network-scenario` job, select the Aztec docker image registry based on the repository for release-tag runs, instead of hardcoding `aztecprotocol/aztec:${tag}`: - `AztecProtocol/aztec-packages-private` → `INTERNAL_DOCKER_REGISTRY` (masked) - everything else → `aztecprotocol` (public) Also wires `INTERNAL_DOCKER_REGISTRY` into the step env. ## Why The nightly Spartan scenario tests run on the **private** repo from `v5.*` nightly tags (cut from `v5-next`), so the executing `ci3.yml` is the one on `v5-next`. There it still pulled `aztecprotocol/aztec:${tag}` from the public registry, which does not hold the private/internal image. This is the same public/private split already used for `deploy-staging-internal` vs `deploy-staging-public` (`use_internal_docker_registry`), and is a backport of the equivalent change already on `next` (commit `01f1bc5e9a8`, "chore: deployments", A-1163) that was not carried over to `v5-next`. --- *Created by [claudebox](https://claudebox.work/v2/sessions/e39ae8121349e17d) · group: `slackbot`*
2 parents c3c4043 + f6f8d9d commit 36fb411

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

.github/workflows/ci3.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,7 @@ jobs:
254254
DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }}
255255
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
256256
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
257+
INTERNAL_DOCKER_REGISTRY: ${{ secrets.INTERNAL_DOCKER_REGISTRY }}
257258
CI3_INSTANCE_PROFILE_NAME: ${{ secrets.CI3_INSTANCE_PROFILE_NAME }}
258259
CI3_SECURITY_GROUP_ID: ${{ secrets.CI3_SECURITY_GROUP_ID }}
259260
RUN_ID: ${{ github.run_id }}
@@ -269,7 +270,16 @@ jobs:
269270
tag="${tag#v}"
270271
major_version=$(./ci3/semver major "$tag")
271272
namespace="v${major_version}-scenario"
272-
docker_image="aztecprotocol/aztec:${tag}"
273+
case "$GITHUB_REPOSITORY" in
274+
AztecProtocol/aztec-packages-private)
275+
image_registry="${INTERNAL_DOCKER_REGISTRY%/}"
276+
echo "::add-mask::${image_registry}"
277+
;;
278+
*)
279+
image_registry="aztecprotocol"
280+
;;
281+
esac
282+
docker_image="${image_registry}/aztec:${tag}"
273283
else
274284
# branch name
275285
namespace=pr-$(echo "$HEAD_REF" | sed 's/[^a-z0-9-]/-/g' | cut -c1-20 | sed 's/-*$//')

0 commit comments

Comments
 (0)