Commit 3aa3849
committed
fix: serialise wsdb node-delete key as canonical uint256
decrement_node_reference_count passed the raw fr nodeHash to delete_value,
while write_node/read_node wrap it in FrKeyType (uint256). In bb the raw fr
went through serialise_key's explicit uint256_t overload (implicit fr->uint256
conversion), so all three agreed. The extracted lmdblib replaced that overload
with a generic serialise_key<T> template, which binds fr exactly and emits the
field's Montgomery-form bytes instead of canonical uint256 bytes. Node deletes
then targeted the wrong key, collaterally deleting retained nodes during unwind
and corrupting the tree (the l1_to_l2 cross_chain e2e regression). Wrap the key
in FrKeyType at the delete site so all node ops serialise the key identically.
Also add native-packages/.clang-format (copied from barretenberg/cpp) so the
new C++ packages format to bb's style.1 parent d5700c2 commit 3aa3849
2 files changed
Lines changed: 35 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
Lines changed: 9 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | 12 | | |
17 | 13 | | |
18 | 14 | | |
19 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
283 | 283 | | |
284 | 284 | | |
285 | 285 | | |
286 | | - | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
287 | 291 | | |
288 | 292 | | |
289 | 293 | | |
| |||
0 commit comments