Merge pull request #562 from AztecProtocol/cb/bb-deadcode-cleanup

chore(bb): remove dead code in barretenberg C++ (unused files, helpers, flavor constants)

Author: ludamad

barretenberg/cpp/src/barretenberg/common/map.hpp

@@ -21,8 +21,6 @@ Cont<OutElem> map(Cont<InElem, Args...> const& in, F&& op)
 
 /*
  * Generic map function for mapping a std::array's elements to another type.
- * TODO: this has only been added because I (Mike) couldn't get the above to work
- * with an array.
  */
 template <std::size_t SIZE,
           typename InElem,
@@ -34,32 +32,4 @@ std::array<OutElem, SIZE> map(std::array<InElem, SIZE> const& in, F&& op)
     std::transform(in.begin(), in.end(), result.begin(), op);
     return result;
 }
-
-/*
- * Generic map function for mapping a containers element to another type.
- * This version passes the element index as a second argument to the operator function.
- */
-template <template <typename, typename...> typename Cont,
-          typename InElem,
-          typename... Args,
-          typename F,
-          typename OutElem = typename std::invoke_result<F, InElem const&, size_t>::type>
-Cont<OutElem> mapi(Cont<InElem, Args...> const& in, F op)
-{
-    Cont<OutElem> result;
-    for (size_t i = 0; i < in.size(); ++i) {
-        result.push_back(op(in[i], i));
-    }
-    return result;
-}
-
-/*
- * Generic filter function for containers.
- */
-template <typename Cont, typename F> Cont filter(Cont const& in, F op)
-{
-    Cont copy(in);
-    std::remove_if(copy.begin(), copy.end(), op);
-    return copy;
-}
 } // namespace bb::transform

barretenberg/cpp/src/barretenberg/common/printf.hpp

@@ -55,9 +55,6 @@ class MegaAvmFlavor : public MegaAVMFlavor_Generated {
     static constexpr size_t BATCHED_RELATION_PARTIAL_LENGTH = MAX_PARTIAL_RELATION_LENGTH + 1;
     static constexpr size_t NUM_RELATIONS = std::tuple_size_v<Relations>;
 
-    static constexpr size_t num_frs_comm = FrCodec::calc_num_fields<Commitment>();
-    static constexpr size_t num_frs_fr = FrCodec::calc_num_fields<FF>();
-
     static constexpr size_t NUM_SUBRELATIONS = compute_number_of_subrelations<Relations>();
     using SubrelationSeparator = FF;
 

barretenberg/cpp/src/barretenberg/flavor/mega_avm_flavor.hpp

@@ -60,9 +60,6 @@ class MegaFlavor : public MegaFlavor_Generated {
     static constexpr size_t BATCHED_RELATION_PARTIAL_LENGTH = MAX_PARTIAL_RELATION_LENGTH + 1;
     static constexpr size_t NUM_RELATIONS = std::tuple_size_v<Relations>;
 
-    static constexpr size_t num_frs_comm = FrCodec::calc_num_fields<Commitment>();
-    static constexpr size_t num_frs_fr = FrCodec::calc_num_fields<FF>();
-
     // A challenge whose powers are used to batch subrelation contributions during Sumcheck
     static constexpr size_t NUM_SUBRELATIONS = compute_number_of_subrelations<Relations>();
     using SubrelationSeparator = FF;

barretenberg/cpp/src/barretenberg/flavor/mega_flavor.hpp

@@ -76,9 +76,6 @@ class MegaZKFlavor : public MegaZKFlavor_Generated {
                   "LIBRA_UNIVARIATES_LENGTH must be equal to MegaZKFlavor::BATCHED_RELATION_PARTIAL_LENGTH");
     static constexpr size_t NUM_RELATIONS = std::tuple_size_v<Relations>;
 
-    static constexpr size_t num_frs_comm = FrCodec::calc_num_fields<Commitment>();
-    static constexpr size_t num_frs_fr = FrCodec::calc_num_fields<FF>();
-
     // A challenge whose powers are used to batch subrelation contributions during Sumcheck
     static constexpr size_t NUM_SUBRELATIONS = compute_number_of_subrelations<Relations>();
     using SubrelationSeparator = FF;

barretenberg/cpp/src/barretenberg/flavor/mega_zk_flavor.hpp

@@ -71,9 +71,6 @@ class UltraFlavor : public UltraFlavor_Generated {
     static constexpr size_t BATCHED_RELATION_PARTIAL_LENGTH = MAX_PARTIAL_RELATION_LENGTH + 1;
     static constexpr size_t NUM_RELATIONS = std::tuple_size_v<Relations>;
 
-    static constexpr size_t num_frs_comm = FrCodec::calc_num_fields<Commitment>();
-    static constexpr size_t num_frs_fr = FrCodec::calc_num_fields<FF>();
-
     // HasZK_-parameterized AllEntities — switches between the non-ZK and ZK generated
     // AllEntities so UltraFlavorWithZK can reuse this surface (UltraZK only adds a masking column,
     // not any new entity *shapes*). The base-class `AllEntities<DataType>` from