Commit 4433c06
authored
chore: resolve
### `field_t` Issues and Resolutions Tracker
For more details, see the comments below.
| ID | Title | Status |
| --- |
--------------------------------------------------------------------------------------------
| ------ |
| 17 | `test_slice_random` not covering the entire input space | `slice`
is replaced with a simpler method `split_at` |
| 16 | Unexpected random value in `test_slice_random` | `slice` is
replaced with a simpler method `split_at` |
| 15 | \[opt] Duplicate constraint in `invert` | ✅ |
| 14 | `set_public` on constant `field_t` passes `IS_CONSTANT` as a wire
index | added the assertion that the input is not constant |
| 13 | \[opt] Multiplication by zero in `field_t` not canonicalized to
constant | ❌ (breaks bigfield assertions + no efficiency gains in real
circuits) |
| 12 | \[opt] `decompose_into_bits` with `num_bits = 253` does
unnecessary aliasing check | deleted |
| 11 | \[doc] Incorrect documentation of `slice` method | `slice` is
replaced with a simpler method `split_at` |
| 10 | Missing builder context validation in field operations | ✅ |
| 9 | \[doc] Confusing comment in `accumulate` | ✅ |
| 8 | \[opt] `assert_equal` optimization | ✅ |
| 7 | Unnecessary witness multiplied by 0 in `normalize` | ✅ |
| 6 | \[opt] `madd` could be optimized when 2 inputs are constant | ✅ |
| 5 | Inconsistent naming of PLONK gate terms | Made the comments
consistent with the naming in gate-related structs |
| 4 | `bool_t` has a constructor that takes context and value | ✅ |
| 3 | Use `get_value` to get a boolean value | ✅ |
| 2 | No restriction on `num_bits` in `ranged_less_than` | ✅ |
| 1 | \[doc] Assumption over `ranged_less_than` is overly restrictive,
method comment has mistakes | ✅ |field_t issues from external audit (#16210)1 parent 7d0a49b commit 4433c06
6 files changed
Lines changed: 514 additions & 414 deletions
File tree
- barretenberg/cpp
- scripts
- src/barretenberg/stdlib
- honk_verifier
- primitives/field
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
294 | | - | |
| 294 | + | |
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
| |||
0 commit comments