fix: drop unused NESTED_RECURSIVE_PROOF_LENGTH imports orphaned by the parity method merge

Deleting getRootParityProof removed the last uses of NESTED_RECURSIVE_PROOF_LENGTH
in mock_prover.ts and broker_prover_facade.ts; @typescript-eslint/no-unused-vars
is error-level so yarn lint would fail. Also corrects two 'base parity' JSDoc
lines to 'inbox parity'.

Author: spalladino

yarn-project/noir-protocol-circuits-types/src/execution/server.ts

@@ -76,8 +76,8 @@ import type { DecodedInputs } from '../utils/decoded_inputs.js';
 export { mapAvmCircuitPublicInputsToNoir } from '../conversion/server.js';
 
 /**
- * Converts the inputs of the base parity circuit into a witness map.
- * @param inputs - The base parity inputs.
+ * Converts the inputs of the inbox parity circuit into a witness map.
+ * @param inputs - The inbox parity inputs.
  * @returns The witness map
  */
 export function convertInboxParityPrivateInputsToWitnessMap(
@@ -472,8 +472,8 @@ export function convertRootRollupOutputsFromWitnessMap(outputs: WitnessMap, simu
 }
 
 /**
- * Converts the outputs of the base parity circuit from a witness map.
- * @param outputs - The base parity outputs as a witness map.
+ * Converts the outputs of the inbox parity circuit from a witness map.
+ * @param outputs - The inbox parity outputs as a witness map.
  * @returns The public inputs.
  */
 export function convertInboxParityOutputsFromWitnessMap(

yarn-project/prover-client/src/proving_broker/broker_prover_facade.ts

@@ -1,6 +1,5 @@
 import type {
   AVM_V2_PROOF_LENGTH_IN_FIELDS,
-  NESTED_RECURSIVE_PROOF_LENGTH,
   NESTED_RECURSIVE_ROLLUP_HONK_PROOF_LENGTH,
   RECURSIVE_PROOF_LENGTH,
 } from '@aztec/constants';

yarn-project/prover-client/src/test/mock_prover.ts

@@ -1,6 +1,5 @@
 import {
   AVM_V2_PROOF_LENGTH_IN_FIELDS,
-  NESTED_RECURSIVE_PROOF_LENGTH,
   NESTED_RECURSIVE_ROLLUP_HONK_PROOF_LENGTH,
   RECURSIVE_PROOF_LENGTH,
 } from '@aztec/constants';