chore: narrow barretenberg API headers

Author: ludamad

barretenberg/cpp/src/barretenberg/api/api_chonk.cpp

@@ -2,7 +2,7 @@
 #include "barretenberg/api/file_io.hpp"
 #include "barretenberg/api/json_output.hpp"
 #include "barretenberg/api/log.hpp"
-#include "barretenberg/bbapi/bbapi.hpp"
+#include "barretenberg/bbapi/bbapi_chonk.hpp"
 #include "barretenberg/chonk/chonk.hpp"
 #include "barretenberg/chonk/chonk_verifier.hpp"
 #include "barretenberg/chonk/mock_circuit_producer.hpp"

barretenberg/cpp/src/barretenberg/api/api_msgpack.hpp

@@ -5,12 +5,14 @@
 #include <memory>
 #include <string>
 
+namespace bb {
+
 #ifndef __wasm__
-#include "barretenberg/ipc/ipc_server.hpp"
+namespace ipc {
+class IpcServer;
+}
 #endif
 
-namespace bb {
-
 /**
  * @brief Process msgpack API commands from an input stream
  *

barretenberg/cpp/src/barretenberg/bb/cli.cpp

@@ -23,16 +23,15 @@
 #include "barretenberg/api/file_io.hpp"
 #include "barretenberg/bb/cli11_formatter.hpp"
 #include "barretenberg/bb/curve_constants.hpp"
-#include "barretenberg/bbapi/bbapi.hpp"
-#include "barretenberg/bbapi/bbapi_ultra_honk.hpp"
-#include "barretenberg/bbapi/c_bind.hpp"
+#include "barretenberg/bbapi/bbapi_schema.hpp"
 #include "barretenberg/common/assert.hpp"
 #include "barretenberg/common/bb_bench.hpp"
 #include "barretenberg/common/get_bytecode.hpp"
 #include "barretenberg/common/memory_profile.hpp"
 #include "barretenberg/common/thread.hpp"
 #include "barretenberg/common/version.hpp"
 #include "barretenberg/dsl/acir_format/serde/index.hpp"
+#include "barretenberg/polynomials/backing_memory.hpp"
 #include "barretenberg/srs/factories/native_crs_factory.hpp"
 #include "barretenberg/srs/global_crs.hpp"
 #include "barretenberg/vm2/api_avm.hpp"

barretenberg/cpp/src/barretenberg/bbapi/bbapi_execute.cpp

@@ -1,6 +1,27 @@
 #include "bbapi_execute.hpp"
+#include <type_traits>
+#include <utility>
 
 namespace bb::bbapi {
+
+CommandResponse execute(BBApiRequest& request, Command&& command)
+{
+    // Reset error state before execution
+    request.error_message.clear();
+
+    CommandResponse response = std::move(command).visit([&request](auto&& cmd) -> CommandResponse {
+        using CmdType = std::decay_t<decltype(cmd)>;
+        return std::forward<CmdType>(cmd).execute(request);
+    });
+
+    // Check if an error occurred during execution
+    if (!request.error_message.empty()) {
+        return ErrorResponse{ .message = std::move(request.error_message) };
+    }
+
+    return response;
+}
+
 namespace { // anonymous
 struct Api {
     Command commands;

barretenberg/cpp/src/barretenberg/bbapi/bbapi_execute.hpp

@@ -6,6 +6,7 @@
 #include "barretenberg/bbapi/bbapi_ecc.hpp"
 #include "barretenberg/bbapi/bbapi_ecdsa.hpp"
 #include "barretenberg/bbapi/bbapi_schnorr.hpp"
+#include "barretenberg/bbapi/bbapi_schema.hpp"
 #include "barretenberg/bbapi/bbapi_shared.hpp"
 #include "barretenberg/bbapi/bbapi_srs.hpp"
 #include "barretenberg/bbapi/bbapi_ultra_honk.hpp"
@@ -148,26 +149,6 @@ using CommandResponse = NamedUnion<ErrorResponse,
  * @param request The circuit registry (acting as the request context).
  * @return A variant of all possible command responses.
  */
-inline CommandResponse execute(BBApiRequest& request, Command&& command)
-{
-    // Reset error state before execution
-    request.error_message.clear();
-
-    CommandResponse response = std::move(command).visit([&request](auto&& cmd) -> CommandResponse {
-        using CmdType = std::decay_t<decltype(cmd)>;
-        return std::forward<CmdType>(cmd).execute(request);
-    });
-
-    // Check if an error occurred during execution
-    if (!request.error_message.empty()) {
-        return ErrorResponse{ .message = std::move(request.error_message) };
-    }
-
-    return response;
-}
-
-// The msgpack scheme is an ad-hoc format that allows for cbind/compiler.ts to
-// generate TypeScript bindings for the API.
-std::string get_msgpack_schema_as_json();
+CommandResponse execute(BBApiRequest& request, Command&& command);
 
 } // namespace bb::bbapi

barretenberg/cpp/src/barretenberg/bbapi/bbapi_schema.hpp

@@ -0,0 +1,9 @@
+#pragma once
+
+#include <string>
+
+namespace bb::bbapi {
+
+std::string get_msgpack_schema_as_json();
+
+} // namespace bb::bbapi