Skip to content

Commit 6e9c50d

Browse files
committed
AI fix of AI issue
1 parent 0af57d4 commit 6e9c50d

File tree

1 file changed

+13
-11
lines changed
  • noir-projects/noir-contracts/contracts/app/orderbook_contract/src

1 file changed

+13
-11
lines changed

noir-projects/noir-contracts/contracts/app/orderbook_contract/src/test.nr

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,15 @@ unconstrained fn setup_orderbook_with_tokens(
5858
}
5959

6060
// Utility function to mint tokens to private balance
61+
// Note: The minting must be done by the token owner (admin), not the recipient
6162
unconstrained fn mint_to_private(
6263
env: TestEnvironment,
6364
token_address: AztecAddress,
65+
owner: AztecAddress,
6466
to: AztecAddress,
6567
amount: u128,
6668
) {
67-
env.call_private(to, Token::at(token_address).mint_to_private(to, amount));
69+
env.call_private(owner, Token::at(token_address).mint_to_private(to, amount));
6870
}
6971

7072
// Utility function to check private balance
@@ -105,7 +107,7 @@ unconstrained fn test_create_order_happy_path() {
105107
let authwit_nonce = 1;
106108

107109
// Mint tokens to owner
108-
mint_to_private(env, token0_address, owner, bid_amount);
110+
mint_to_private(env, token0_address, owner, owner, bid_amount);
109111

110112
// Create authwit for transferring tokens to orderbook
111113
let transfer_call_interface = Token::at(token0_address).transfer_to_public(
@@ -145,8 +147,8 @@ unconstrained fn test_fulfill_order_happy_path() {
145147
let authwit_nonce_fulfill = 2;
146148

147149
// Setup: mint tokens to maker and taker
148-
mint_to_private(env, token0_address, maker, bid_amount);
149-
mint_to_private(env, token1_address, taker, ask_amount);
150+
mint_to_private(env, token0_address, maker, maker, bid_amount);
151+
mint_to_private(env, token1_address, maker, taker, ask_amount);
150152

151153
// Create order first
152154
let transfer_call_interface = Token::at(token0_address).transfer_to_public(
@@ -354,7 +356,7 @@ unconstrained fn test_create_order_missing_authwit() {
354356
let authwit_nonce = 1;
355357

356358
// Mint tokens to owner
357-
mint_to_private(env, token0_address, owner, bid_amount);
359+
mint_to_private(env, token0_address, owner, owner, bid_amount);
358360

359361
// Don't create authwit - this should fail
360362

@@ -385,7 +387,7 @@ unconstrained fn test_fulfill_order_insufficient_balance() {
385387
let authwit_nonce_fulfill = 2;
386388

387389
// Setup: mint tokens to maker only (not to taker)
388-
mint_to_private(env, token0_address, maker, bid_amount);
390+
mint_to_private(env, token0_address, maker, maker, bid_amount);
389391

390392
// Create order first
391393
let transfer_call_interface = Token::at(token0_address).transfer_to_public(
@@ -441,8 +443,8 @@ unconstrained fn test_fulfill_order_missing_authwit() {
441443
let authwit_nonce_fulfill = 2;
442444

443445
// Setup: mint tokens to maker and taker
444-
mint_to_private(env, token0_address, maker, bid_amount);
445-
mint_to_private(env, token1_address, taker, ask_amount);
446+
mint_to_private(env, token0_address, maker, maker, bid_amount);
447+
mint_to_private(env, token1_address, maker, taker, ask_amount);
446448

447449
// Create order first
448450
let transfer_call_interface = Token::at(token0_address).transfer_to_public(
@@ -483,7 +485,7 @@ unconstrained fn test_get_order_active() {
483485
let authwit_nonce = 1;
484486

485487
// Mint tokens to owner
486-
mint_to_private(env, token0_address, owner, bid_amount);
488+
mint_to_private(env, token0_address, owner, owner, bid_amount);
487489

488490
// Create authwit for transferring tokens to orderbook
489491
let transfer_call_interface = Token::at(token0_address).transfer_to_public(
@@ -528,8 +530,8 @@ unconstrained fn test_get_order_fulfilled() {
528530
let authwit_nonce_fulfill = 2;
529531

530532
// Setup: mint tokens to maker and taker
531-
mint_to_private(env, token0_address, maker, bid_amount);
532-
mint_to_private(env, token1_address, taker, ask_amount);
533+
mint_to_private(env, token0_address, maker, maker, bid_amount);
534+
mint_to_private(env, token1_address, maker, taker, ask_amount);
533535

534536
// Create order first
535537
let transfer_call_interface = Token::at(token0_address).transfer_to_public(

0 commit comments

Comments
 (0)