Skip to content

Commit 740b7e7

Browse files
authored
test: fix web3signer pipelining e2e_multi_validator_node_key_store.test.ts (#23568)
Fix web3signer e2e `e2e_multi_validator_node_key_store.test.ts` by removing the minTxsPerBlock override so the pipelining preset can publish empty checkpoints while txs arrive. Also anchors the test PXE to the checkpointed chain tip to prevent checkpoint prunes from killing sent txs.
1 parent a304325 commit 740b7e7

2 files changed

Lines changed: 18 additions & 29 deletions

File tree

.test_patterns.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -379,20 +379,6 @@ tests:
379379
owners:
380380
- *spyros
381381

382-
# Multi-validator web3signer suite is unstable under proposer pipelining:
383-
# two distinct failure modes have been seen in the same "should build blocks
384-
# & attest with multiple validator keys" case — Promise.all index-0
385-
# waitForTx aborting with "Tx dropped by P2P node"
386-
# (ci.aztec-labs.com/9a5fa90aa18f62e7), and the proposer missing the slot's
387-
# 5-attestation deadline ("AttestationTimeoutError" / "Block .* not found .*
388-
# reorg") on PR #23344 run 26370196367 (ci.aztec-labs.com/b91d3218b5e88ae4).
389-
# Error-regex flake matches still let ci3 retry-and-fail both attempts. Skip
390-
# outright on merge-train/spartan until proposer pipelining stabilises.
391-
- regex: "yarn-project/end-to-end/scripts/run_test.sh web3signer src/composed/web3signer/e2e_multi_validator_node_key_store.test.ts"
392-
skip: true
393-
owners:
394-
- *palla
395-
396382
# http://ci.aztec-labs.com/98d59d04f85223f8
397383
# Build-cache flake: module not found during Jest startup
398384
- regex: "src/e2e_sequencer/gov_proposal.parallel.test.ts"

yarn-project/end-to-end/src/composed/web3signer/e2e_multi_validator_node_key_store.test.ts

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -284,21 +284,24 @@ describe('e2e_multi_validator_node', () => {
284284
deployL1ContractsValues,
285285
aztecNode,
286286
sequencer: sequencerClient,
287-
} = await setup(1, {
288-
...PIPELINING_SETUP_OPTS,
289-
initialValidators,
290-
aztecTargetCommitteeSize: COMMITTEE_SIZE,
291-
keyStoreDirectory,
292-
minTxsPerBlock: 1,
293-
maxTxsPerBlock: 1,
294-
archiverPollingIntervalMS: 200,
295-
sequencerPollingIntervalMS: 200,
296-
worldStateBlockCheckIntervalMS: 200,
297-
blockCheckIntervalMS: 200,
298-
startProverNode: true,
299-
aztecEpochDuration: 8,
300-
aztecProofSubmissionEpochs: 4,
301-
}));
287+
} = await setup(
288+
1,
289+
{
290+
...PIPELINING_SETUP_OPTS,
291+
initialValidators,
292+
aztecTargetCommitteeSize: COMMITTEE_SIZE,
293+
keyStoreDirectory,
294+
maxTxsPerBlock: 1,
295+
archiverPollingIntervalMS: 200,
296+
sequencerPollingIntervalMS: 200,
297+
worldStateBlockCheckIntervalMS: 200,
298+
blockCheckIntervalMS: 200,
299+
startProverNode: true,
300+
aztecEpochDuration: 8,
301+
aztecProofSubmissionEpochs: 4,
302+
},
303+
{ syncChainTip: 'checkpointed' },
304+
));
302305

303306
sequencer = (sequencerClient! as TestSequencerClient).getSequencer();
304307
publisherFactory = (sequencer as TestSequencer).publisherFactory;

0 commit comments

Comments
 (0)