chore: update more tests

Author: MirandaWood

barretenberg/cpp/src/barretenberg/vm2/constraining/relations/ecc.test.cpp

@@ -1183,7 +1183,7 @@ TEST(EccAddMemoryConstrainingTest, EccAddMemoryInvalidDstRange)
 
     StrictMock<MockExecutionIdManager> execution_id_manager;
     EXPECT_CALL(execution_id_manager, get_execution_id)
-        .WillRepeatedly(Return(0)); // Use a fixed execution IDfor the test
+        .WillRepeatedly(Return(0)); // Use a fixed execution ID for the test
     PureGreaterThan gt;
     PureToRadix to_radix_simulator = PureToRadix();
 
@@ -1194,7 +1194,7 @@ TEST(EccAddMemoryConstrainingTest, EccAddMemoryInvalidDstRange)
                                scalar_mul_event_emitter,
                                ecc_add_memory_event_emitter);
 
-    uint32_t dst_address = AVM_HIGHEST_MEM_ADDRESS - 1; // Invalid address, will result in out of range error
+    uint32_t dst_address = AVM_HIGHEST_MEM_ADDRESS; // Invalid address, will result in out of range error
     // Set the execution and gt traces
     TestTraceContainer trace = TestTraceContainer({
         // Row 0

barretenberg/cpp/src/barretenberg/vm2/simulation/gadgets/ecc.test.cpp

@@ -148,7 +148,7 @@ TEST(AvmSimulationEccTest, AddWithMemory)
     MemoryStore memory;
 
     EXPECT_CALL(execution_id_manager, get_execution_id()).WillOnce(Return(0));
-    EXPECT_CALL(gt, gt(0x1000 + 2, AVM_HIGHEST_MEM_ADDRESS)).WillOnce(Return(false));
+    EXPECT_CALL(gt, gt(0x1000 + 1, AVM_HIGHEST_MEM_ADDRESS)).WillOnce(Return(false));
 
     Ecc ecc(
         execution_id_manager, gt, to_radix, ecc_event_emitter, scalar_mul_event_emitter, ecc_add_memory_event_emitter);
@@ -184,7 +184,7 @@ TEST(AvmSimulationEccTest, AddNotOnCurve)
     MemoryStore memory;
 
     EXPECT_CALL(execution_id_manager, get_execution_id()).WillOnce(Return(0));
-    EXPECT_CALL(gt, gt(0x1000 + 2, AVM_HIGHEST_MEM_ADDRESS)).WillOnce(Return(false));
+    EXPECT_CALL(gt, gt(0x1000 + 1, AVM_HIGHEST_MEM_ADDRESS)).WillOnce(Return(false));
 
     Ecc ecc(
         execution_id_manager, gt, to_radix, ecc_event_emitter, scalar_mul_event_emitter, ecc_add_memory_event_emitter);
@@ -215,7 +215,7 @@ TEST(AvmSimulationEccTest, InfinityOnCurve)
     MemoryStore memory;
 
     EXPECT_CALL(execution_id_manager, get_execution_id()).WillOnce(Return(0));
-    EXPECT_CALL(gt, gt(0x1000 + 2, AVM_HIGHEST_MEM_ADDRESS)).WillOnce(Return(false));
+    EXPECT_CALL(gt, gt(0x1000 + 1, AVM_HIGHEST_MEM_ADDRESS)).WillOnce(Return(false));
 
     Ecc ecc(
         execution_id_manager, gt, to_radix, ecc_event_emitter, scalar_mul_event_emitter, ecc_add_memory_event_emitter);
@@ -248,7 +248,7 @@ TEST(AvmSimulationEccTest, AddsUpToInfinity)
     MemoryStore memory;
 
     EXPECT_CALL(execution_id_manager, get_execution_id()).WillOnce(Return(0));
-    EXPECT_CALL(gt, gt(0x1000 + 2, AVM_HIGHEST_MEM_ADDRESS)).WillOnce(Return(false));
+    EXPECT_CALL(gt, gt(0x1000 + 1, AVM_HIGHEST_MEM_ADDRESS)).WillOnce(Return(false));
 
     Ecc ecc(
         execution_id_manager, gt, to_radix, ecc_event_emitter, scalar_mul_event_emitter, ecc_add_memory_event_emitter);