Skip to content

Commit 7e1dc3d

Browse files
committed
chore(fast-inbox): fix l1 publisher revert assertion after inHash removal (A-1387)
The propose-failure test asserted the deleted Rollup__InvalidInHash selector (0xcd6f4233). With the legacy inHash L1 check gone, a checkpoint carrying messages that do not match the Inbox now reverts at validateInboxConsumption with Rollup__InvalidInboxRollingHash (0xed1f7bb5).
1 parent 79be6f4 commit 7e1dc3d

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

yarn-project/sequencer-client/src/publisher/l1_publisher.integration.test.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -968,9 +968,8 @@ describe('L1Publisher integration', () => {
968968
});
969969

970970
it(`shows propose custom errors if tx simulation fails`, async () => {
971-
// Set up different l1-to-l2 messages than the ones on the inbox, so this submission reverts because the
972-
// INBOX.consume does not match the header.inHash and we get a Rollup__BlobHash that is not caught by
973-
// validateHeader before.
971+
// Set up different l1-to-l2 messages than the ones on the inbox, so the checkpoint's inboxRollingHash does not
972+
// match the referenced Inbox bucket and the submission reverts at the streaming-consumption check.
974973
const l1ToL2Messages = new Array(MAX_L1_TO_L2_MSGS_PER_CHECKPOINT).fill(new Fr(1n));
975974
const { checkpoint } = await buildSingleCheckpoint({ l1ToL2Messages });
976975

@@ -986,12 +985,12 @@ describe('L1Publisher integration', () => {
986985
await progressToSlot(BigInt(checkpoint.header.slotNumber));
987986
const result = await publisher.sendRequests();
988987
expect(result).toBeUndefined();
989-
// 0xcd6f4233 == Rollup__InvalidInHash selector
988+
// 0xed1f7bb5 == Rollup__InvalidInboxRollingHash selector
990989
expect(loggerWarnSpy).toHaveBeenCalledWith(
991990
'Bundle entry dropped: action reverted in sim',
992991
expect.objectContaining({
993992
action: 'propose',
994-
returnData: expect.stringMatching(/^0xcd6f4233/),
993+
returnData: expect.stringMatching(/^0xed1f7bb5/),
995994
}),
996995
);
997996
});

0 commit comments

Comments
 (0)