Commit 849cca6
fix: skip heavy recursion tests in debug builds, keep one for assertion coverage (#22389)
## Summary
Fixes nightly barretenberg debug build failure (CI run
https://github.com/AztecProtocol/aztec-packages/actions/runs/24228497408).
**Root cause:** `AvmRecursionInnerCircuitTests.Tampering` from
`vm2_tests` timed out at 600s. CI log:
http://ci.aztec-labs.com/ee4d306df4cbfd3c
**Fix:**
1. Add `AvmRecursionInnerCircuitTests` to the debug build skip list
(matching PR #22446 pattern)
2. Reinstate
`HonkRecursionConstraintTestWithoutPredicate/1.GenerateVKFromConstraints`
(241s, well within timeout) so the debug-only
`native_verification_debug` code path in
`honk_recursion_constraint.cpp:126` is still exercised
**Debug assertion audit of all skipped suites:**
- `HonkRecursionConstraintTest`: The only unique debug code is
`native_verification_debug` (`#ifndef NDEBUG`, line 126) — a native
side-verification sanity check. All tampering tests call
`BB_DISABLE_ASSERTS()` so no debug assertions fire there. We keep
`/1.GenerateVKFromConstraints` to cover this.
- `ChonkRecursionConstraintTest`: All `BB_ASSERT_DEBUG` in `chonk.cpp`
are disabled by `BB_DISABLE_ASSERTS()` in the test. `ChonkTests`
tampering (separate binary, not skipped) still runs.
- `AvmRecursionInnerCircuitTests`: Only `BB_ASSERT_LTE` (circuit size
bounds) which is hit on the happy path by `AvmRecursiveTests`.
ClaudeBox log: https://claudebox.work/s/7d8cbad767a56122?run=51 parent c8d22e2 commit 849cca6
1 file changed
+6
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
250 | | - | |
251 | | - | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
252 | 256 | | |
253 | 257 | | |
254 | 258 | | |
| |||
0 commit comments