Commit 93d3d0a
authored
fix(kv-store): lazy-load skipped browser benchmark deps (#24108)
## Summary
- Investigated the `merge-train/spartan-v5` dequeue for train PR #24053.
- Latest dequeue was from merge-group CI, not a merge conflict: #24053
is currently mergeable/clean on `merge-train/spartan-v5`.
- The failing merge-group run was `27576008840` on
`gh-readonly-queue/v5-next/pr-24053-fc2322d6...`, failing `ci/x3-full`
via `yarn-project/kv-store/scripts/run_test.sh
src/bench/sqlite-opfs-encrypted/map_bench.test.ts`.
- Root cause: skipped-by-default browser benchmarks still imported
SQLite/OPFS and shared benchmark dependencies at module load, so normal
CI test discovery could fail before the `describe.skip` path.
- Fix: lazy-load benchmark dependencies only when `VITE_BENCH=1` for the
IndexedDB, SQLite-OPFS, and encrypted SQLite-OPFS map benchmarks.
Failed dashboard log: http://ci.aztec-labs.com/dbe70cb905f2df69
## Verification
- `CI=1 PATH="$HOME/.cargo/bin:$PATH" scripts/run_test.sh
src/bench/sqlite-opfs-encrypted/map_bench.test.ts` from
`yarn-project/kv-store` passes with the benchmark skipped.
- `CI=1 PATH="$HOME/.cargo/bin:$PATH" scripts/run_test.sh
src/bench/sqlite-opfs/map_bench.test.ts` passes with the benchmark
skipped.
- `CI=1 PATH="$HOME/.cargo/bin:$PATH" scripts/run_test.sh
src/bench/indexeddb/map_bench.test.ts` passes with the benchmark
skipped.
- `yarn format kv-store --check` passes.
Notes: the requested root `./bootstrap.sh ci` is not a valid bootstrap
command in this checkout (`Unknown command: ci`). I also tried the
apparent CI equivalent, `./bootstrap.sh ci-full-no-test-cache`; it did
not complete in this container because the local CI engine/tooling
failed before reaching these tests.
---
*Created by
[claudebox](https://claudebox.work/v2/sessions/72862d04194777fa) ·
group: `slackbot`*1 parent fbfbca2 commit 93d3d0a
3 files changed
Lines changed: 21 additions & 18 deletions
File tree
- yarn-project/kv-store/src/bench
- indexeddb
- sqlite-opfs-encrypted
- sqlite-opfs
Lines changed: 7 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 6 | | |
13 | 7 | | |
14 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
Lines changed: 7 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | 12 | | |
19 | 13 | | |
20 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
Lines changed: 7 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 6 | | |
13 | 7 | | |
14 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
0 commit comments