Skip to content

Commit 9a59ef0

Browse files
authored
feat(ci): notify #team-fairies when backwards-compat e2e fails on nightly (#23006)
Forward-port of #23003 (merged to v4-next via the backport-staging branch) onto `merge-train/fairies`, to keep the v4 ↔ v5 diff small. ## Summary Same change as #23003: wraps `bootstrap_ec2 "./bootstrap.sh ci-compat-e2e"` in `ci.sh` so that on a `-nightly.*` tag a failing run posts to `#team-fairies` via the existing `ci3/slack_notify` helper, then exits with the captured rc (so GH job result is unchanged). The compat-e2e job is `continue-on-error: true` on nightlies (`.github/workflows/ci3.yml`), so failures otherwise go unnoticed. Cherry-picked cleanly from b9c2250 — no conflicts. Closes [F-632](https://linear.app/aztec-labs/issue/F-632/notify-team-fairies-channel-when-backwards-compat-fails) on the v5 line. ClaudeBox log: https://claudebox.work/s/a0aa5c1e0994ac85?run=2
1 parent a98f6d1 commit 9a59ef0

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

ci.sh

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,15 @@ case "$cmd" in
312312
export CI_DASHBOARD="releases"
313313
export JOB_ID="x-compat-e2e"
314314
export AWS_SHUTDOWN_TIME=300
315-
bootstrap_ec2 "./bootstrap.sh ci-compat-e2e"
315+
rc=0
316+
bootstrap_ec2 "./bootstrap.sh ci-compat-e2e" || rc=$?
317+
# On nightly tags compat-e2e is non-blocking (continue-on-error in ci3.yml), so
318+
# failures otherwise go unnoticed. Notify #team-fairies so they get picked up.
319+
if [ "$rc" -ne 0 ] && [[ "${REF_NAME:-}" == *-nightly.* ]]; then
320+
run_url="https://github.com/${GITHUB_REPOSITORY:-AztecProtocol/aztec-packages}/actions/runs/${GITHUB_RUN_ID:-unknown}"
321+
"$ci3/slack_notify" "Backwards compatibility e2e tests FAILED on nightly tag <${run_url}|${REF_NAME}>" "#team-fairies"
322+
fi
323+
exit "$rc"
316324
;;
317325

318326
############

0 commit comments

Comments
 (0)