rm yarn-project changes

Author: critesjosh

docs/docs-developers/docs/tutorials/contract_tutorials/counter_contract.md

@@ -118,9 +118,7 @@ Now let's implement an `increment` function to increase the counter.
 
 #include_code increment /docs/examples/contracts/counter_contract/src/main.nr rust
 
-The `increment` function uses `self.msg_sender()` so each caller can only increment the counter mapped to their own address. It logs a debug message, then adds 1 to that counter and delivers the note onchain.
-
-Only this mutating action derives the owner from the caller. The one-time `constructor` and the `get_counter` read still take an explicit `owner`: the constructor can seed a chosen account, and a read selects which counter to view (only its owner can decrypt it).
+The `increment` function works similarly to the `constructor`. It logs a debug message, then adds 1 to the `owner`'s counter and delivers the note onchain.
 
 ## Getting a counter
 

docs/examples/contracts/counter_contract/src/main.nr

@@ -35,8 +35,7 @@ pub contract Counter {
 
     // docs:start:increment
     #[external("private")]
-    fn increment() {
-        let owner = self.msg_sender();
+    fn increment(owner: AztecAddress) {
         debug_log_format("Incrementing counter for owner {0}", [owner.to_field()]);
         self.storage.counters.at(owner).add(1).deliver(MessageDelivery::onchain_constrained());
     }

docs/examples/contracts/counter_contract_test/src/lib.nr

@@ -21,35 +21,13 @@ unconstrained fn test_constructor_sets_initial_value() {
 }
 
 #[test]
-unconstrained fn test_increment_increases_caller_counter() {
+unconstrained fn test_increment() {
     let initial_value = 5;
     let (mut env, contract_address, owner) = setup(initial_value);
 
-    env.call_private(owner, Counter::at(contract_address).increment());
+    env.call_private(owner, Counter::at(contract_address).increment(owner));
 
     let expected = initial_value + 1;
     let value = env.execute_utility(Counter::at(contract_address).get_counter(owner));
     assert(value == expected, f"Expected {expected} but got {value}");
 }
-
-#[test]
-unconstrained fn test_stranger_increment_does_not_affect_owner() {
-    let initial_value = 5;
-    let (mut env, contract_address, owner) = setup(initial_value);
-    let stranger = env.create_light_account();
-
-    // `increment` derives the owner from msg_sender, so a different caller can
-    // only ever touch its own counter, never the owner's.
-    env.call_private(stranger, Counter::at(contract_address).increment());
-
-    // The stranger's increment lands on their own counter, which started at 0.
-    let stranger_value = env.execute_utility(Counter::at(contract_address).get_counter(stranger));
-    assert(stranger_value == 1, f"Expected stranger counter at 1 but got {stranger_value}");
-
-    // The owner's counter is untouched by another account's increment.
-    let owner_value = env.execute_utility(Counter::at(contract_address).get_counter(owner));
-    assert(
-        owner_value == initial_value,
-        f"Expected owner counter unchanged at {initial_value} but got {owner_value}",
-    );
-}

yarn-project/aztec/scripts/templates/counter/contract/src/main.nr

@@ -31,13 +31,9 @@ pub contract Counter {
         );
     }
 
-    // Adds 1 to the caller's own counter.
-    //
-    // The owner is read from self.msg_sender(), so a caller can only ever
-    // increment the counter mapped to their own address.
+    // Adds 1 to the owner's counter.
     #[external("private")]
-    fn increment() {
-        let owner = self.msg_sender();
+    fn increment(owner: AztecAddress) {
         self.storage.counters.at(owner).add(1).deliver(MessageDelivery::onchain_constrained());
     }
 

yarn-project/aztec/scripts/templates/counter/test/src/lib.nr

@@ -25,7 +25,7 @@ unconstrained fn test_increment() {
     let initial_value = 5;
     let (mut env, contract_address, owner) = setup(initial_value);
 
-    env.call_private(owner, Counter::at(contract_address).increment());
+    env.call_private(owner, Counter::at(contract_address).increment(owner));
 
     let counter = env.execute_utility(Counter::at(contract_address).get_counter(owner));
     assert_eq(counter, initial_value + 1);