feat: slash attesters signing over bad checkpoints

Author: alexghr

spartan/aztec-node/templates/_pod-template.yaml

@@ -253,6 +253,10 @@ spec:
         - name: SLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY
           value: {{ .Values.node.slash.attestDescendantOfInvalidPenalty | quote }}
         {{- end }}
+        {{- if .Values.node.slash.attestInvalidCheckpointProposalPenalty }}
+        - name: SLASH_ATTEST_INVALID_CHECKPOINT_PROPOSAL_PENALTY
+          value: {{ .Values.node.slash.attestInvalidCheckpointProposalPenalty | quote }}
+        {{- end }}
         {{- if .Values.node.slash.unknownPenalty }}
         - name: SLASH_UNKNOWN_PENALTY
           value: {{ .Values.node.slash.unknownPenalty | quote }}

spartan/aztec-node/values.yaml

@@ -155,6 +155,7 @@ node:
     invalidBlockPenalty: ""
     proposeInvalidAttestationsPenalty: ""
     attestDescendantOfInvalidPenalty: ""
+    attestInvalidCheckpointProposalPenalty: ""
     unknownPenalty: ""
     # Slasher behavior configuration
     gracePeriodL2Slots: ""

spartan/environments/network-defaults.yml

@@ -133,6 +133,8 @@ slasher: &slasher
   SLASH_PROPOSE_INVALID_ATTESTATIONS_PENALTY: 10e18
   # Penalty for attesting to a descendant of an invalid block.
   SLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY: 10e18
+  # Penalty for attesting to an invalid checkpoint proposal.
+  SLASH_ATTEST_INVALID_CHECKPOINT_PROPOSAL_PENALTY: 10e18
   # Penalty for proposing two different block or checkpoint proposal for the same position.
   SLASH_DUPLICATE_PROPOSAL_PENALTY: 0
   # Penalty for signing attestations for different proposals at the same slot.
@@ -242,6 +244,7 @@ networks:
     SLASH_DUPLICATE_PROPOSAL_PENALTY: 10e18
     SLASH_DUPLICATE_ATTESTATION_PENALTY: 10e18
     SLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY: 10e18
+    SLASH_ATTEST_INVALID_CHECKPOINT_PROPOSAL_PENALTY: 10e18
     SLASH_UNKNOWN_PENALTY: 10e18
     SLASH_INVALID_BLOCK_PENALTY: 10e18
     SLASH_GRACE_PERIOD_L2_SLOTS: 0
@@ -287,6 +290,7 @@ networks:
     SLASH_DUPLICATE_PROPOSAL_PENALTY: 10e18
     SLASH_DUPLICATE_ATTESTATION_PENALTY: 10e18
     SLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY: 10e18
+    SLASH_ATTEST_INVALID_CHECKPOINT_PROPOSAL_PENALTY: 10e18
     SLASH_UNKNOWN_PENALTY: 10e18
     SLASH_INVALID_BLOCK_PENALTY: 10e18
     SLASH_GRACE_PERIOD_L2_SLOTS: 64
@@ -346,6 +350,7 @@ networks:
     SLASH_DUPLICATE_PROPOSAL_PENALTY: 2000e18
     SLASH_DUPLICATE_ATTESTATION_PENALTY: 2000e18
     SLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY: 2000e18
+    SLASH_ATTEST_INVALID_CHECKPOINT_PROPOSAL_PENALTY: 2000e18
     SLASH_UNKNOWN_PENALTY: 2000e18
     SLASH_INVALID_BLOCK_PENALTY: 2000e18
     SLASH_GRACE_PERIOD_L2_SLOTS: 1200

spartan/scripts/deploy_network.sh

@@ -592,6 +592,7 @@ SLASH_PROPOSE_INVALID_ATTESTATIONS_PENALTY = ${SLASH_PROPOSE_INVALID_ATTESTATION
 SLASH_DUPLICATE_PROPOSAL_PENALTY = ${SLASH_DUPLICATE_PROPOSAL_PENALTY:-null}
 SLASH_DUPLICATE_ATTESTATION_PENALTY = ${SLASH_DUPLICATE_ATTESTATION_PENALTY:-null}
 SLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY = ${SLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY:-null}
+SLASH_ATTEST_INVALID_CHECKPOINT_PROPOSAL_PENALTY = ${SLASH_ATTEST_INVALID_CHECKPOINT_PROPOSAL_PENALTY:-null}
 SLASH_UNKNOWN_PENALTY = ${SLASH_UNKNOWN_PENALTY:-null}
 SLASH_INVALID_BLOCK_PENALTY = ${SLASH_INVALID_BLOCK_PENALTY:-null}
 SLASH_OFFENSE_EXPIRATION_ROUNDS = ${SLASH_OFFENSE_EXPIRATION_ROUNDS:-null}

spartan/terraform/deploy-aztec-infra/main.tf

@@ -206,6 +206,7 @@ locals {
     "validator.slash.duplicateProposalPenalty"                    = var.SLASH_DUPLICATE_PROPOSAL_PENALTY
     "validator.slash.duplicateAttestationPenalty"                 = var.SLASH_DUPLICATE_ATTESTATION_PENALTY
     "validator.slash.attestDescendantOfInvalidPenalty"            = var.SLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY
+    "validator.slash.attestInvalidCheckpointProposalPenalty"       = var.SLASH_ATTEST_INVALID_CHECKPOINT_PROPOSAL_PENALTY
     "validator.slash.unknownPenalty"                              = var.SLASH_UNKNOWN_PENALTY
     "validator.slash.invalidBlockPenalty"                         = var.SLASH_INVALID_BLOCK_PENALTY
     "validator.slash.offenseExpirationRounds"                     = var.SLASH_OFFENSE_EXPIRATION_ROUNDS

spartan/terraform/deploy-aztec-infra/variables.tf

@@ -502,6 +502,12 @@ variable "SLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY" {
   nullable    = true
 }
 
+variable "SLASH_ATTEST_INVALID_CHECKPOINT_PROPOSAL_PENALTY" {
+  description = "The slash attest invalid checkpoint proposal penalty"
+  type        = string
+  nullable    = true
+}
+
 variable "SLASH_UNKNOWN_PENALTY" {
   description = "The slash unknown penalty"
   type        = string

yarn-project/foundation/src/config/env_var.ts

@@ -250,6 +250,7 @@ export type EnvVar =
   | 'SLASH_OVERRIDE_PAYLOAD'
   | 'SLASH_PROPOSE_INVALID_ATTESTATIONS_PENALTY'
   | 'SLASH_ATTEST_DESCENDANT_OF_INVALID_PENALTY'
+  | 'SLASH_ATTEST_INVALID_CHECKPOINT_PROPOSAL_PENALTY'
   | 'SLASH_UNKNOWN_PENALTY'
   | 'SLASH_GRACE_PERIOD_L2_SLOTS'
   | 'SLASH_OFFENSE_EXPIRATION_ROUNDS'

yarn-project/p2p/src/client/interface.ts

@@ -18,6 +18,7 @@ import type {
   DuplicateAttestationInfo,
   DuplicateProposalInfo,
   P2PBlockReceivedCallback,
+  P2PCheckpointAttestationCallback,
   P2PCheckpointReceivedCallback,
 } from '../services/service.js';
 
@@ -109,6 +110,9 @@ export type P2P = P2PClient & {
    */
   registerDuplicateAttestationCallback(callback: (info: DuplicateAttestationInfo) => void): void;
 
+  /** Registers a callback invoked when a valid checkpoint attestation is accepted into the pool. */
+  registerCheckpointAttestationCallback(callback: P2PCheckpointAttestationCallback): void;
+
   /**
    * Verifies the 'tx' and, if valid, adds it to local tx pool and forwards it to other peers.
    * @param tx - The transaction.

yarn-project/p2p/src/client/p2p_client.ts

@@ -421,6 +421,10 @@ export class P2PClient extends WithTracer implements P2P {
     this.p2pService.registerDuplicateAttestationCallback(callback);
   }
 
+  public registerCheckpointAttestationCallback(callback: (attestation: CheckpointAttestation) => void): void {
+    this.p2pService.registerCheckpointAttestationCallback(callback);
+  }
+
   public async getPendingTxs(limit?: number, after?: TxHash): Promise<Tx[]> {
     if (limit !== undefined && limit <= 0) {
       throw new TypeError('limit must be greater than 0');

yarn-project/p2p/src/services/dummy_service.ts

@@ -25,6 +25,7 @@ import type { GoodByeReason } from './reqresp/protocols/goodbye.js';
 import { ReqRespStatus } from './reqresp/status.js';
 import {
   type P2PBlockReceivedCallback,
+  type P2PCheckpointAttestationCallback,
   type P2PCheckpointReceivedCallback,
   type P2PDuplicateAttestationCallback,
   type P2PDuplicateProposalCallback,
@@ -103,6 +104,8 @@ export class DummyP2PService implements P2PService {
    */
   public registerDuplicateAttestationCallback(_callback: P2PDuplicateAttestationCallback): void {}
 
+  public registerCheckpointAttestationCallback(_callback: P2PCheckpointAttestationCallback): void {}
+
   /**
    * Sends a request to a peer.
    * @param _protocol - The protocol to send the request on.