Merge branch 'v5-next' into merge-train/fairies-v5

Author: vezenovm

avm-transpiler/Cargo.lock

@@ -258,7 +258,9 @@ where
         };
     }
 
-    BoundedVec::from_parts(confirmed_notes_bvec_storage, hinted_notes.len())
+    // We can use `from_parts_unchecked` instead of `from_parts` because we know that `confirmed_notes_bvec_storage`
+    // contains all zeroes past `hinted_notes.len()` due to how it was initialized.
+    BoundedVec::from_parts_unchecked(confirmed_notes_bvec_storage, hinted_notes.len())
 }
 
 pub unconstrained fn view_note<Note>(owner: Option<AztecAddress>, storage_slot: Field) -> HintedNote<Note>

noir-projects/aztec-nr/aztec/src/note/note_getter.nr

@@ -19,9 +19,11 @@ pub fn subbvec<T, let SrcMaxLen: u32, let DstMaxLen: u32>(
     bvec: BoundedVec<T, SrcMaxLen>,
     offset: u32,
 ) -> BoundedVec<T, DstMaxLen> {
-    // The new storage array is a subarray of the original one (which has zeroed storage past len), so elements past
-    // the new len remain zeroed: `subarray` does not allow extending arrays past their original length.
-    BoundedVec::from_parts(array::subarray(bvec.storage(), offset), bvec.len() - offset)
+    // from_parts_unchecked does not verify that the elements past len are zeroed, but that is not an issue in our case
+    // because we're constructing the new storage array as a subarray of the original one (which should have zeroed
+    // storage past len), guaranteeing correctness. This is because `subarray` does not allow extending arrays past
+    // their original length.
+    BoundedVec::from_parts_unchecked(array::subarray(bvec.storage(), offset), bvec.len() - offset)
 }
 
 mod test {