Skip to content

Commit bf0485c

Browse files
committed
cleanup
1 parent 310c65e commit bf0485c

2 files changed

Lines changed: 2 additions & 7 deletions

File tree

  • noir-projects/noir-contracts/contracts/test/public_fns_with_emit_repro_contract/src
  • yarn-project/simulator/src/public/public_tx_simulator/apps_tests

noir-projects/noir-contracts/contracts/test/public_fns_with_emit_repro_contract/src/main.nr

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ use aztec::macros::aztec;
55
/// 15 `#[external("public")]` functions, each doing one storage read, one storage write,
66
/// and one `self.emit(Updated { .. })`. Pinned here so that:
77
/// - `nargo expand` is snapshotted in `noir-projects/contract-snapshots`, making any
8-
/// change to the `self.emit(event)` -> `emit_event_in_public(...)` macro rewrite
9-
/// visible across all 15 call sites in a single review.
8+
/// change to the macro boilerplate visible across all 15 call sites in a single review.
109
/// - `bytecodeSizeBytes/PublicFnsWithEmitRepro` lands on the bench dashboard, so any
1110
/// improvement (or regression) in the per-public-fn emit shape is tracked over time.
1211
#[aztec]

yarn-project/simulator/src/public/public_tx_simulator/apps_tests/bench.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,7 @@ describe('Public TX simulator apps tests: benchmarks', () => {
138138
});
139139

140140
it('PublicFnsWithEmitRepro contract test', async () => {
141-
// Tracks bytecode size of a contract shaped like the public-dispatch repro from
142-
// https://github.com/AztecProtocol/aztec-nr/issues/35: 15 public fns, each doing
143-
// one storage read, one storage write, and one event emit. None of the other
144-
// bench targets exercise this shape, so improvements/regressions in the macro
145-
// emit-in-public rewrite would otherwise be invisible on the dashboard.
141+
// See comments on the contract source for motivation as to including this contract in our benchmarks.
146142
tester.setMetricsPrefix(`${metricsPrefixPrefix}PublicFnsWithEmitRepro contract tests`);
147143
const deployer = AztecAddress.fromNumber(42);
148144

0 commit comments

Comments
 (0)